ShuriZma
/
pokerogue
mirror of https://github.com/pagefaultgames/pokerogue.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[Refactor] Remove obsolete comments in egg gacha and starter select UIs (#4542)

This commit is contained in:
NightKev 2024-10-01 18:58:16 -07:00 committed by GitHub
parent c46507d49b
commit a6bcd6eeea
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/ui/egg-gacha-ui-handler.ts
View File

@ -8,7 +8,7 @@ import { VoucherType, getVoucherTypeIcon } from "../system/voucher";
import { getPokemonSpecies } from "../data/pokemon-species"; import { getPokemonSpecies } from "../data/pokemon-species";
import { addWindow } from "./ui-theme"; import { addWindow } from "./ui-theme";
import { Tutorial, handleTutorial } from "../tutorial"; import { Tutorial, handleTutorial } from "../tutorial";
import {Button} from "#enums/buttons"; import { Button } from "#enums/buttons";
import Overrides from "#app/overrides"; import Overrides from "#app/overrides";
import { GachaType } from "#app/enums/gacha-types"; import { GachaType } from "#app/enums/gacha-types";
import i18next from "i18next"; import i18next from "i18next";
@ -99,7 +99,7 @@ export default class EggGachaUiHandler extends MessageUiHandler {
const gachaInfoContainer = this.scene.add.container(160, 46); const gachaInfoContainer = this.scene.add.container(160, 46);
const currentLanguage = i18next.resolvedLanguage!; // TODO: is this bang correct? const currentLanguage = i18next.resolvedLanguage ?? "en";
let gachaTextStyle = TextStyle.WINDOW_ALT; let gachaTextStyle = TextStyle.WINDOW_ALT;
let gachaX = 4; let gachaX = 4;
let gachaY = 0; let gachaY = 0;
@ -217,7 +217,7 @@ export default class EggGachaUiHandler extends MessageUiHandler {
{ multiplier: multiplierOne, description: `25 ${i18next.t("egg:pulls")}`, icon: getVoucherTypeIcon(VoucherType.GOLDEN) } { multiplier: multiplierOne, description: `25 ${i18next.t("egg:pulls")}`, icon: getVoucherTypeIcon(VoucherType.GOLDEN) }
]; ];
const resolvedLanguage = i18next.resolvedLanguage ?? "en"; // TODO: is this bang correct? const resolvedLanguage = i18next.resolvedLanguage ?? "en";
const pullOptionsText = pullOptions.map(option =>{ const pullOptionsText = pullOptions.map(option =>{
const desc = option.description.split(" "); const desc = option.description.split(" ");
if (desc[0].length < 2) { if (desc[0].length < 2) {

4
src/ui/starter-select-ui-handler.ts
View File

@ -358,8 +358,8 @@ export default class StarterSelectUiHandler extends MessageUiHandler {
setup() { setup() {
const ui = this.getUi(); const ui = this.getUi();
const currentLanguage = i18next.resolvedLanguage ?? "en"; // TODO: is this bang correct? const currentLanguage = i18next.resolvedLanguage ?? "en";
const langSettingKey = Object.keys(languageSettings).find(lang => currentLanguage.includes(lang)) ?? "en"; // TODO: is this bang correct? const langSettingKey = Object.keys(languageSettings).find(lang => currentLanguage.includes(lang)) ?? "en";
const textSettings = languageSettings[langSettingKey]; const textSettings = languageSettings[langSettingKey];
this.starterSelectContainer = this.scene.add.container(0, -this.scene.game.canvas.height / 6); this.starterSelectContainer = this.scene.add.container(0, -this.scene.game.canvas.height / 6);