ShuriZma
/
pokerogue
mirror of https://github.com/pagefaultgames/pokerogue.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Apply suggestions from code review 

Co-authored-by: flx-sta <50131232+flx-sta@users.noreply.github.com>
This commit is contained in:
ImperialSympathizer 2024-07-19 19:56:55 -04:00 committed by GitHub
parent e765b3a455
commit 8814175906
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/data/mystery-encounters/utils/encounter-phase-utils.ts
View File

@ -636,11 +636,11 @@ export function transitionMysteryEncounterIntroVisuals(scene: BattleScene, hide:
// Transition // Transition
scene.tweens.add({ scene.tweens.add({
targets: introVisuals, targets: introVisuals,
x: hide ? "+=16" : "-=16", x: `${hide? "+" : "-"}=16`,
y: hide ? "-=16" : "+=16", y: `${hide ? "-" : "+"}=16`,
alpha: hide ? 0 : 1, alpha: hide ? 0 : 1,
ease: "Sine.easeInOut", ease: "Sine.easeInOut",
duration: duration, duration,
onComplete: () => { onComplete: () => {
if (hide && destroy) { if (hide && destroy) {
scene.field.remove(introVisuals); scene.field.remove(introVisuals);

2
src/test/utils/overridesHelper.ts
View File

@ -45,7 +45,7 @@ export class OverridesHelper {
* @param encounterType * @param encounterType
* @returns spy instance * @returns spy instance
*/ */
mysteryEncounter(encounterType: MysteryEncounterType): MockInstance { mysteryEncounter(encounterType: MysteryEncounterType) {
const spy = vi.spyOn(overrides, "MYSTERY_ENCOUNTER_OVERRIDE", "get").mockReturnValue(encounterType); const spy = vi.spyOn(overrides, "MYSTERY_ENCOUNTER_OVERRIDE", "get").mockReturnValue(encounterType);
this.log(`Mystery encounter override set to ${encounterType}!`); this.log(`Mystery encounter override set to ${encounterType}!`);
return spy; return spy;