pcsx2/pcsx2-qt
Dan McCarthy ecd3b87cc0
Debugger: Fix Importing Breakpoints CSV functionality (#10486)
* Debugger: Fix Importing Breakpoints CSV functionality

This resolves a few issues with the Breakpoint CSV importing functionality.
Makes the following changes/fixes:
-  Assembly instructions with commas caused part of the instruction text to be considered the start of a new column (comma is the CSV delimiter), resulting in "too many columns errors" and failing to import. Now puts values in quotes and detects the true start and end of the values, so that no extra columns are created.
- The import function was using the incorrect columns to load since the Enabled column was moved to be the first one but the import function had not been updated. Fixed this by using the column enum values instead of hardcoded numbers, so if ordering in the model changes it will still import fine.
- Updates the beginRemoveRows function to not remove an extra row. With this function you would want a "count" of 0 to remove 1, so "row, row" deletes one, "row, row+1" deletes 2. Updates it to subtract one so that the range is not including one more than it is intended to.
-

* Misc: Cleanup regex string & add explicit imports

Uses raw string literal to make the regular expression easier to read since regex is ugly enough as it is, we really don't need escaping characters in a string on top.

Also explicitly includes used Qt classes.
2023-12-30 14:01:30 +10:00
..
Debugger Debugger: Fix Importing Breakpoints CSV functionality (#10486) 2023-12-30 14:01:30 +10:00
GameList Misc: Remove explicit PCH include, switch to SPDX 2023-12-24 14:03:14 +10:00
Settings Qt: Fix game properties dialog not activating 2023-12-28 18:35:11 +10:00
Tools/InputRecording Misc: Remove explicit PCH include, switch to SPDX 2023-12-24 14:03:14 +10:00
Translations Qt: Update Base Translation 2023-12-30 14:00:42 +10:00
resources Qt: Small icon changes to profile buttons 2023-10-17 23:57:02 +01:00
AboutDialog.cpp Misc: Remove explicit PCH include, switch to SPDX 2023-12-24 14:03:14 +10:00
AboutDialog.h Misc: Remove explicit PCH include, switch to SPDX 2023-12-24 14:03:14 +10:00
AboutDialog.ui Qt:i18n: Adding I18N comments for translators, minor typo fixes (#8048) 2023-03-18 16:14:55 -05:00
AutoUpdaterDialog.cpp Qt: Fix AutoUpdaterDialog building 2023-12-27 14:34:48 +10:00
AutoUpdaterDialog.h Misc: Remove explicit PCH include, switch to SPDX 2023-12-24 14:03:14 +10:00
AutoUpdaterDialog.ui Qt/Updater: Move download size indicator to better placement 2023-10-17 13:10:34 +10:00
CMakeLists.txt CMake: Don't compile PrecompiledHeader.cpp 2023-12-25 12:39:08 +10:00
ColorPickerButton.cpp Misc: Remove explicit PCH include, switch to SPDX 2023-12-24 14:03:14 +10:00
ColorPickerButton.h Misc: Remove explicit PCH include, switch to SPDX 2023-12-24 14:03:14 +10:00
CoverDownloadDialog.cpp Misc: Remove explicit PCH include, switch to SPDX 2023-12-24 14:03:14 +10:00
CoverDownloadDialog.h Misc: Remove explicit PCH include, switch to SPDX 2023-12-24 14:03:14 +10:00
CoverDownloadDialog.ui Qt: Icon Revamps 2023-06-15 20:51:15 +10:00
DisplayWidget.cpp Misc: Remove explicit PCH include, switch to SPDX 2023-12-24 14:03:14 +10:00
DisplayWidget.h Misc: Remove explicit PCH include, switch to SPDX 2023-12-24 14:03:14 +10:00
EarlyHardwareCheck.cpp Misc: Remove explicit PCH include, switch to SPDX 2023-12-24 14:03:14 +10:00
MainWindow.cpp Misc: Remove explicit PCH include, switch to SPDX 2023-12-24 14:03:14 +10:00
MainWindow.h Misc: Remove explicit PCH include, switch to SPDX 2023-12-24 14:03:14 +10:00
MainWindow.ui Qt: Add Edit Cheats/Patches to Tools menu 2023-09-10 11:19:53 +10:00
PrecompiledHeader.cpp Misc: Remove explicit PCH include, switch to SPDX 2023-12-24 14:03:14 +10:00
PrecompiledHeader.h Misc: Remove explicit PCH include, switch to SPDX 2023-12-24 14:03:14 +10:00
QtHost.cpp QT: Add ability to pass launch arguments with CLI option -gameargs 2023-12-28 22:18:20 +10:00
QtHost.h Misc: Remove explicit PCH include, switch to SPDX 2023-12-24 14:03:14 +10:00
QtKeyCodes.cpp Misc: Remove explicit PCH include, switch to SPDX 2023-12-24 14:03:14 +10:00
QtProgressCallback.cpp Misc: Remove explicit PCH include, switch to SPDX 2023-12-24 14:03:14 +10:00
QtProgressCallback.h Misc: Remove explicit PCH include, switch to SPDX 2023-12-24 14:03:14 +10:00
QtUtils.cpp Debugger: Fix Importing Breakpoints CSV functionality (#10486) 2023-12-30 14:01:30 +10:00
QtUtils.h Debugger: Fix Importing Breakpoints CSV functionality (#10486) 2023-12-30 14:01:30 +10:00
SettingWidgetBinder.h Misc: Remove explicit PCH include, switch to SPDX 2023-12-24 14:03:14 +10:00
SetupWizardDialog.cpp Misc: Remove explicit PCH include, switch to SPDX 2023-12-24 14:03:14 +10:00
SetupWizardDialog.h Misc: Remove explicit PCH include, switch to SPDX 2023-12-24 14:03:14 +10:00
SetupWizardDialog.ui Qt: Fix links in first page of Setup Wizard 2023-12-04 14:20:41 +10:00
Themes.cpp Misc: Remove explicit PCH include, switch to SPDX 2023-12-24 14:03:14 +10:00
Translations.cpp Misc: Remove explicit PCH include, switch to SPDX 2023-12-24 14:03:14 +10:00
pcsx2-qt.vcxproj Qt: Fix AutoUpdaterDialog building 2023-12-27 14:34:48 +10:00
pcsx2-qt.vcxproj.filters Qt: Change settings windows from QDialog to QWidget 2023-10-14 21:00:33 +10:00