mirror of https://github.com/PCSX2/pcsx2.git
ecd3b87cc0
* Debugger: Fix Importing Breakpoints CSV functionality This resolves a few issues with the Breakpoint CSV importing functionality. Makes the following changes/fixes: - Assembly instructions with commas caused part of the instruction text to be considered the start of a new column (comma is the CSV delimiter), resulting in "too many columns errors" and failing to import. Now puts values in quotes and detects the true start and end of the values, so that no extra columns are created. - The import function was using the incorrect columns to load since the Enabled column was moved to be the first one but the import function had not been updated. Fixed this by using the column enum values instead of hardcoded numbers, so if ordering in the model changes it will still import fine. - Updates the beginRemoveRows function to not remove an extra row. With this function you would want a "count" of 0 to remove 1, so "row, row" deletes one, "row, row+1" deletes 2. Updates it to subtract one so that the range is not including one more than it is intended to. - * Misc: Cleanup regex string & add explicit imports Uses raw string literal to make the regular expression easier to read since regex is ugly enough as it is, we really don't need escaping characters in a string on top. Also explicitly includes used Qt classes. |
||
|---|---|---|
| .. | ||
| Models | ||
| BreakpointDialog.cpp | ||
| BreakpointDialog.h | ||
| BreakpointDialog.ui | ||
| CpuWidget.cpp | ||
| CpuWidget.h | ||
| CpuWidget.ui | ||
| DebuggerWindow.cpp | ||
| DebuggerWindow.h | ||
| DebuggerWindow.ui | ||
| DisassemblyWidget.cpp | ||
| DisassemblyWidget.h | ||
| DisassemblyWidget.ui | ||
| MemoryViewWidget.cpp | ||
| MemoryViewWidget.h | ||
| MemoryViewWidget.ui | ||
| RegisterWidget.cpp | ||
| RegisterWidget.h | ||
| RegisterWidget.ui | ||