ShuriZma
/
pcsx2
mirror of https://github.com/PCSX2/pcsx2.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

GS/TextureCache: Unswizzle shared texture formats when hashing 

Fixes formats such as PSMT4HL giving different hashes depending on what
the overlapping/shared pixels in local memory contain.

Enable this unconditionally, rather than only when dumping, because
unswizzling and hashing is around 25% faster on AVX2 builds than hashing
the backing local memory for larger textures (e.g. Star Ocean 3 menus).
Also has the added bonus of hitting the cache more often in such cases
too.
This commit is contained in:
Connor McLaughlin 2022-06-23 22:18:55 +10:00 committed by refractionpcsx2
parent 6e84e5ce9c
commit efc09a7b47
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
pcsx2/GS/Renderers/HW/GSTextureCache.cpp
View File

@ -2936,7 +2936,12 @@ static void HashTextureLevel(const GIFRegTEX0& TEX0, const GIFRegTEXA& TEXA, Blo
// For textures which are smaller than the block size, we expand and then hash.
// This is because otherwise we get the padding bytes, which can be random junk.
if (tw < bs.x || th < bs.y)
// We also expand formats where the bits contributing to the texture do not cover
// all the 32 bits, as otherwise we'll get differing hash values if game overlap
// the texture data with other textures/framebuffers/etc (which is common).
// Even though you might think this would be slower than just hashing for the hash
// cache, it actually ends up faster (unswizzling is faster than hashing).
if (tw < bs.x || th < bs.y || psm.fmsk != 0xFFFFFFFFu)
{
// Expand texture indices. Align to 32 bytes for AVX2.
const u32 pitch = Common::AlignUpPow2(static_cast<u32>(block_rect.w), 32);