ShuriZma
/
pcsx2
mirror of https://github.com/PCSX2/pcsx2.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

microVU: fix aliasing issue 

Union is safer for the compiler
This commit is contained in:
Gregory Hainaut 2016-07-27 23:36:25 +02:00
parent e8e66ec4b5
commit ef7530af29
1 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
pcsx2/x86/microVU.cpp
View File

@ -191,16 +191,20 @@ __ri void mVUcacheProg(microVU& mVU, microProgram& prog) {
// Generate Hash for partial program based on compiled ranges... // Generate Hash for partial program based on compiled ranges...
u64 mVUrangesHash(microVU& mVU, microProgram& prog) { u64 mVUrangesHash(microVU& mVU, microProgram& prog) {
u32 hash[2] = {0, 0}; union {
u64 v64;
u32 v32[2];
} hash = {0};
std::deque<microRange>::const_iterator it(prog.ranges->begin()); std::deque<microRange>::const_iterator it(prog.ranges->begin());
for ( ; it != prog.ranges->end(); ++it) { for ( ; it != prog.ranges->end(); ++it) {
if((it[0].start<0)||(it[0].end<0)) { DevCon.Error("microVU%d: Negative Range![%d][%d]", mVU.index, it[0].start, it[0].end); } if((it[0].start<0)||(it[0].end<0)) { DevCon.Error("microVU%d: Negative Range![%d][%d]", mVU.index, it[0].start, it[0].end); }
for(int i = it[0].start/4; i < it[0].end/4; i++) { for(int i = it[0].start/4; i < it[0].end/4; i++) {
hash[0] -= prog.data[i]; hash.v32[0] -= prog.data[i];
hash[1] ^= prog.data[i]; hash.v32[1] ^= prog.data[i];
} }
} }
return *(u64*)hash; return hash.v64;
} }
// Prints the ratio of unique programs to total programs // Prints the ratio of unique programs to total programs