From e1651c752a4b63768d86f1741db6b9abb73d94d7 Mon Sep 17 00:00:00 2001
From: Gregory Hainaut <gregory.hainaut@gmail.com>
Date: Sun, 7 Feb 2016 12:23:15 +0100
Subject: [PATCH] EE: mmxregs[i].inuse is never set to true

Let's remove code that depends on it

_deleteMMXreg/_checkMMXreg/_getNumMMXwrite/_flushMMXunused are now stub
---
 pcsx2/x86/ix86-32/iCore-32.cpp  | 61 ---------------------------------
 pcsx2/x86/ix86-32/iR5900-32.cpp | 14 --------
 2 files changed, 75 deletions(-)

diff --git a/pcsx2/x86/ix86-32/iCore-32.cpp b/pcsx2/x86/ix86-32/iCore-32.cpp
index 0119f1f126..7a6a1a038d 100644
--- a/pcsx2/x86/ix86-32/iCore-32.cpp
+++ b/pcsx2/x86/ix86-32/iCore-32.cpp
@@ -502,33 +502,6 @@ __fi void* _MMXGetAddr(int reg)
 
 int _checkMMXreg(int reg, int mode)
 {
-	uint i;
-	for (i=0; i<iREGCNT_MMX; i++) {
-		if (mmxregs[i].inuse && mmxregs[i].reg == reg ) {
-
-			if( !(mmxregs[i].mode & MODE_READ) && (mode&MODE_READ) ) {
-
-				if( reg == MMX_GPR ) {
-					// moving in 0s
-					xPXOR(xRegisterMMX(i), xRegisterMMX(i));
-				}
-				else {
-					if (MMX_ISGPR(reg) && (mode&(MODE_READHALF|MODE_READ))) _flushConstReg(reg-MMX_GPR);
-					if( (mode & MODE_READHALF) || (MMX_IS32BITS(reg)&&(mode&MODE_READ)) )
-						xMOVDZX(xRegisterMMX(i), ptr[(_MMXGetAddr(reg))]);
-					else
-						xMOVQ(xRegisterMMX(i), ptr[(_MMXGetAddr(reg))]);
-				}
-				SetMMXstate();
-			}
-
-			mmxregs[i].mode |= mode;
-			mmxregs[i].counter = g_mmxAllocCounter++;
-			mmxregs[i].needed = 1;
-			return i;
-		}
-	}
-
 	return -1;
 }
 
@@ -548,45 +521,11 @@ void _clearNeededMMXregs()
 
 void _deleteMMXreg(int reg, int flush)
 {
-	uint i;
-	for (i=0; i<iREGCNT_MMX; i++) {
-
-		if (mmxregs[i].inuse && mmxregs[i].reg == reg ) {
-
-			switch(flush) {
-				case 0: // frees all of the reg
-					_freeMMXreg(i);
-					break;
-				case 1: // flushes all of the reg
-					if( mmxregs[i].mode & MODE_WRITE) {
-						pxAssert( mmxregs[i].reg != MMX_GPR );
-
-						if( MMX_IS32BITS(reg) )
-							xMOVD(ptr[(_MMXGetAddr(mmxregs[i].reg))], xRegisterMMX(i));
-						else
-							xMOVQ(ptr[(_MMXGetAddr(mmxregs[i].reg))], xRegisterMMX(i));
-						SetMMXstate();
-
-						// get rid of MODE_WRITE since don't want to flush again
-						mmxregs[i].mode &= ~MODE_WRITE;
-						mmxregs[i].mode |= MODE_READ;
-					}
-					return;
-				case 2: // just stops using the reg (no flushing)
-					mmxregs[i].inuse = 0;
-					break;
-			}
-			return;
-		}
-	}
 }
 
 int _getNumMMXwrite()
 {
 	uint num = 0, i;
-	for (i=0; i<iREGCNT_MMX; i++) {
-		if( mmxregs[i].inuse && (mmxregs[i].mode&MODE_WRITE) ) ++num;
-	}
 
 	return num;
 }
diff --git a/pcsx2/x86/ix86-32/iR5900-32.cpp b/pcsx2/x86/ix86-32/iR5900-32.cpp
index 34d28ee65b..64cc920f6a 100644
--- a/pcsx2/x86/ix86-32/iR5900-32.cpp
+++ b/pcsx2/x86/ix86-32/iR5900-32.cpp
@@ -247,20 +247,6 @@ int _flushXMMunused()
 
 int _flushMMXunused()
 {
-	u32 i;
-	for (i=0; i<iREGCNT_MMX; i++) {
-		if (!mmxregs[i].inuse || mmxregs[i].needed || !(mmxregs[i].mode&MODE_WRITE) ) continue;
-
-		if( MMX_ISGPR(mmxregs[i].reg) ) {
-			//if( !(g_pCurInstInfo->regs[mmxregs[i].reg-MMX_GPR]&EEINST_USED) ) {
-			if( !_recIsRegWritten(g_pCurInstInfo+1, (s_nEndBlock-pc)/4, XMMTYPE_GPRREG, mmxregs[i].reg-MMX_GPR) ) {
-				_freeMMXreg(i);
-				mmxregs[i].inuse = 1;
-				return 1;
-			}
-		}
-	}
-
 	return 0;
 }