From de5f31001105d35a74177dc620dd8baa984ea435 Mon Sep 17 00:00:00 2001
From: lightningterror <18107717+lightningterror@users.noreply.github.com>
Date: Sat, 17 Sep 2022 14:23:53 +0200
Subject: [PATCH] USB: Try to fix variable never used warnings.

Codacy.
---
 pcsx2/USB/usb-pad/dx/dinput.cpp | 31 +++++++++++++++++++++++++------
 1 file changed, 25 insertions(+), 6 deletions(-)

diff --git a/pcsx2/USB/usb-pad/dx/dinput.cpp b/pcsx2/USB/usb-pad/dx/dinput.cpp
index 99d90a7f7a..10c040d9be 100644
--- a/pcsx2/USB/usb-pad/dx/dinput.cpp
+++ b/pcsx2/USB/usb-pad/dx/dinput.cpp
@@ -357,7 +357,6 @@ namespace usb_pad
 
 		void CreateFFB(int port, LPDIRECTINPUTDEVICE8 device, DWORD axis)
 		{
-			HRESULT hres;
 			ReleaseFFB(port);
 
 			if (!device)
@@ -399,26 +398,46 @@ namespace usb_pad
 
 			eff.cbTypeSpecificParams = sizeof(cfw);
 			eff.lpvTypeSpecificParams = &cfw;
-			hres = device->CreateEffect(GUID_ConstantForce, &eff, &g_pEffectConstant[port], NULL);
+			{
+				HRESULT hres = device->CreateEffect(GUID_ConstantForce, &eff, &g_pEffectConstant[port], NULL);
+				if (FAILED(hres))
+					Console.Warning("USB: CreateEffect GUID_ConstantForce error: %x", hres);
+			}
 
 			cSpring.lNegativeCoefficient = 0;
 			cSpring.lPositiveCoefficient = 0;
 
 			effSpring.cbTypeSpecificParams = sizeof(cSpring);
 			effSpring.lpvTypeSpecificParams = &cSpring;
-			hres = device->CreateEffect(GUID_Spring, &effSpring, &g_pEffectSpring[port], NULL);
+			{
+				HRESULT hres = device->CreateEffect(GUID_Spring, &effSpring, &g_pEffectSpring[port], NULL);
+				if (FAILED(hres))
+					Console.Warning("USB: CreateEffect GUID_Spring error: %x", hres);
+			}
 
 			effFriction.cbTypeSpecificParams = sizeof(cFriction);
 			effFriction.lpvTypeSpecificParams = &cFriction;
-			hres = device->CreateEffect(GUID_Friction, &effFriction, &g_pEffectFriction[port], NULL);
+			{
+				HRESULT hres = device->CreateEffect(GUID_Friction, &effFriction, &g_pEffectFriction[port], NULL);
+				if (FAILED(hres))
+					Console.Warning("USB: CreateEffect GUID_Friction error: %x", hres);
+			}
 
 			effRamp.cbTypeSpecificParams = sizeof(cRamp);
 			effRamp.lpvTypeSpecificParams = &cRamp;
-			hres = device->CreateEffect(GUID_RampForce, &effRamp, &g_pEffectRamp[port], NULL);
+			{
+				HRESULT hres = device->CreateEffect(GUID_RampForce, &effRamp, &g_pEffectRamp[port], NULL);
+				if (FAILED(hres))
+					Console.Warning("USB: CreateEffect GUID_RampForce error: %x", hres);
+			}
 
 			effDamper.cbTypeSpecificParams = sizeof(cDamper);
 			effDamper.lpvTypeSpecificParams = &cDamper;
-			hres = device->CreateEffect(GUID_Damper, &effDamper, &g_pEffectDamper[port], NULL);
+			{
+				HRESULT hres = device->CreateEffect(GUID_Damper, &effDamper, &g_pEffectDamper[port], NULL);
+				if (FAILED(hres))
+					Console.Warning("USB: CreateEffect GUID_Damper error: %x", hres);
+			}
 
 			FFB[port] = true;