From dcfd663c1903025864a865d3fcf508d0caab70c7 Mon Sep 17 00:00:00 2001 From: TheTechnician27 Date: Tue, 23 Jul 2024 12:01:26 -0500 Subject: [PATCH] Qt: Simplify compat line in GameSummaryWidget --- pcsx2-qt/Settings/GameSummaryWidget.cpp | 14 +++++--- pcsx2-qt/Settings/GameSummaryWidget.ui | 48 ++----------------------- 2 files changed, 11 insertions(+), 51 deletions(-) diff --git a/pcsx2-qt/Settings/GameSummaryWidget.cpp b/pcsx2-qt/Settings/GameSummaryWidget.cpp index f181693853..a7504234c6 100644 --- a/pcsx2-qt/Settings/GameSummaryWidget.cpp +++ b/pcsx2-qt/Settings/GameSummaryWidget.cpp @@ -35,10 +35,6 @@ GameSummaryWidget::GameSummaryWidget(const GameList::Entry* entry, SettingsWindo m_ui.region->setItemIcon(i, QIcon(QStringLiteral("%1/icons/flags/%2.png").arg(base_path).arg(GameList::RegionToString(static_cast(i))))); } - for (int i = 1; i < m_ui.compatibility->count(); i++) - { - m_ui.compatibility->setItemIcon(i, QIcon(QStringLiteral("%1/icons/star-%2.png").arg(base_path).arg(i))); - } m_entry_path = entry->path; populateInputProfiles(); @@ -76,7 +72,15 @@ void GameSummaryWidget::populateDetails(const GameList::Entry* entry) m_ui.crc->setText(QString::fromStdString(fmt::format("{:08X}", entry->crc))); m_ui.type->setCurrentIndex(static_cast(entry->type)); m_ui.region->setCurrentIndex(static_cast(entry->region)); - m_ui.compatibility->setCurrentIndex(static_cast(entry->compatibility_rating)); + m_ui.compatibility->setText(QString("%0%1") + .arg(GameList::EntryCompatibilityRatingToString(entry->compatibility_rating)) + .arg([entry]() { + if (entry->compatibility_rating == GameList::CompatibilityRating::Unknown) + return QString(); + + const qsizetype compatibility_value = static_cast(entry->compatibility_rating); + return QString(" ") + QString("★").repeated(compatibility_value - 1) + QString("☆").repeated(6 - compatibility_value); + }())); int row = 0; m_ui.detailsFormLayout->getWidgetPosition(m_ui.titleSort, &row, nullptr); diff --git a/pcsx2-qt/Settings/GameSummaryWidget.ui b/pcsx2-qt/Settings/GameSummaryWidget.ui index 9a9289d8f5..f34aab2fa5 100644 --- a/pcsx2-qt/Settings/GameSummaryWidget.ui +++ b/pcsx2-qt/Settings/GameSummaryWidget.ui @@ -377,54 +377,10 @@ - - - false - - - - 0 - 0 - - - + + true - - - Unknown - - - - - Not Bootable - - - - - Reaches Intro - - - - - Reaches Menu - - - - - In-Game - - - - - Playable - - - - - Perfect - -