ShuriZma
/
pcsx2
mirror of https://github.com/PCSX2/pcsx2.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

gsdx-ogl: Move DATE_GL42 swap code after colclip. 

We can avoid adding extra conditions this way.
This commit is contained in:
lightningterror 2020-09-24 21:59:31 +02:00
parent ec1656f380
commit dcfb6a56b3
1 changed files with 13 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
plugins/GSdx/Renderers/OpenGL/GSRendererOGL.cpp
View File

@ -513,18 +513,6 @@ void GSRendererOGL::EmulateBlending(bool& DATE_GL42, bool& DATE_GL45)
default:
/*sw_blending |= accumulation_blend*/;
}
// SW Blending
// GL42 interact very badly with sw blending. GL42 uses the primitiveID to find the primitive
// that write the bad alpha value. Sw blending will force the draw to run primitive by primitive
// (therefore primitiveID will be constant to 1).
// Switch DATE_GL42 with DATE_GL45 in such cases to ensure accuracy.
// No mix of COLCLIP + sw blend + DATE_GL42, neither sw fbmask + DATE_GL42.
if ((((accumulation_blend || blend_non_recursive) && m_env.COLCLAMP.CLAMP == 0) || sw_blending) && DATE_GL42) {
GL_PERF("DATE: Swap DATE_GL42 with DATE_GL45");
m_require_full_barrier = true;
DATE_GL42 = false;
DATE_GL45 = true;
}
// Color clip
if (m_env.COLCLAMP.CLAMP == 0) {
@ -555,6 +543,19 @@ void GSRendererOGL::EmulateBlending(bool& DATE_GL42, bool& DATE_GL45)
}
}
// GL42 interact very badly with sw blending. GL42 uses the primitiveID to find the primitive
// that write the bad alpha value. Sw blending will force the draw to run primitive by primitive
// (therefore primitiveID will be constant to 1).
// Switch DATE_GL42 with DATE_GL45 in such cases to ensure accuracy.
// No mix of COLCLIP + sw blend + DATE_GL42, neither sw fbmask + DATE_GL42.
// Note: Do the swap after colclip to avoid adding extra conditions.
if (sw_blending && DATE_GL42) {
GL_PERF("DATE: Swap DATE_GL42 with DATE_GL45");
m_require_full_barrier = true;
DATE_GL42 = false;
DATE_GL45 = true;
}
// For stat to optimize accurate option
#if 0
GL_INS("BLEND_INFO: %d/%d/%d/%d. Clamp:%d. Prim:%d number %d (drawlist %d) (sw %d)",