plugins: cleaning up more plugin cruft, adding a note on freezeData

pcsx2/DEV9/ATA/ATA.h

@@ -23,9 +23,6 @@
 #include "ghc/filesystem.h"
 #include <fstream>
 
-#include "PS2Edefs.h"
-#include "PS2Eext.h"
-
 #include "../SimpleQueue.h"
 
 class ATA

pcsx2/DEV9/DEV9.h

@@ -25,8 +25,6 @@
 //#define WINVER 0x0600
 //#define _WIN32_WINNT 0x0500
 
-#include "PS2Edefs.h"
-#include "PS2Eext.h"
 #include "net.h"
 #include "PacketReader/IP/IP_Address.h"
 #include "ATA/ATA.h"

pcsx2/IopDma.h

@@ -15,10 +15,6 @@
 
 #pragma once 
 
-#include "PS2Edefs.h"
-
-// defined in PS2Edefs.h
-
 extern void psxDma2(u32 madr, u32 bcr, u32 chcr);
 extern void psxDma3(u32 madr, u32 bcr, u32 chcr);
 extern void psxDma6(u32 madr, u32 bcr, u32 chcr);

pcsx2/PAD/Linux/controller.h

@@ -15,7 +15,6 @@
 
 #pragma once
 #include <string.h> // for memset
-#include "PS2Edefs.h"
 #define MAX_KEYS 24
 
 extern void set_keyboard_key(int pad, int keysym, int index);

pcsx2/PAD/Windows/Global.h

@@ -128,7 +128,5 @@ extern Window GSwin;
 #include <Dbt.h>
 #endif
 
-#include "PS2Edefs.h"
-
 // Needed for config screen
-void GetNameAndVersionString(wchar_t* out);
+void GetNameAndVersionString(wchar_t* out);

pcsx2/PAD/Windows/PAD.h

@@ -24,7 +24,6 @@
 #include "Utilities/Console.h"
 #include <stdio.h>
 #include <assert.h>
-#include "PS2Edefs.h"
 
 #include <array>
 #include <vector>
@@ -57,4 +56,4 @@ s32 PADfreeze(int mode, freezeData* data);
 s32 PADsetSlot(u8 port, u8 slot);
 void PADsetSettingsDir(const char* dir);
 void PADDoFreezeOut(void* dest);
-void PADDoFreezeIn(pxInputStream& infp);
+void PADDoFreezeIn(pxInputStream& infp);

pcsx2/SaveState.h

@@ -15,7 +15,6 @@
 
 #pragma once
 
-#include "PS2Edefs.h"
 #include "System.h"
 
 // Savestate Versioning!
@@ -26,6 +25,18 @@
 
 static const u32 g_SaveVersion = (0x9A1F << 16) | 0x0000;
 
+// the freezing data between submodules and core
+// an interesting thing to note is that this dates back from before plugin
+// merges and was used to pass data between plugins and cores, although the
+// struct was system dependant as the size of int differs between systems, thus
+// subsystems making use of freezeData, like GSDump and save states aren't
+// necessarily portable; we might want to investigate this in the future -- govanify
+typedef struct
+{
+    int size;
+    s8 *data;
+} freezeData;
+
 // this function is meant to be used in the place of GSfreeze, and provides a safe layer
 // between the GS saving function and the MTGS's needs. :)
 extern s32 CALLBACK gsSafeFreeze( int mode, freezeData *data );

pcsx2/System.h

@@ -19,7 +19,6 @@
 
 #include "Utilities/SafeArray.h"
 #include "Utilities/Threading.h"		// to use threading stuff, include the Threading namespace in your file.
-#include "Plugins.h"
 
 #include "vtlb.h"
 

pcsx2/gui/Saveslots.h

@@ -16,7 +16,6 @@
 
 #pragma once
 
-#include "PS2Edefs.h"
 #include "System.h"
 #include "Elfheader.h"
 #include "App.h"
@@ -134,4 +133,4 @@ extern void States_CycleSlotForward();
 extern void States_CycleSlotBackward();
 extern void States_SetCurrentSlot(int slot_num);
 extern int States_GetCurrentSlot();
-extern void States_updateLoadBackupMenuItem();
+extern void States_updateLoadBackupMenuItem();