ShuriZma
/
pcsx2
mirror of https://github.com/PCSX2/pcsx2.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

iop: remove kernelTTYFileDescrWrite debug function 

Recommended by pseudo

Main issue is a buffer underflow when strlen(...) < 2
2nd issue is code is called based on hardcoded address of a single bios.
This commit is contained in:
Gregory Hainaut 2016-11-01 13:41:54 +01:00
parent 270d7191ce
commit c9974b65c4
2 changed files with 0 additions and 44 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
pcsx2/IopMem.cpp
View File

@ -489,7 +489,4 @@ void __fastcall iopMemWrite32(u32 mem, u32 value)
}
}
}
if (mem == 0x000085CC)
kernelTTYFileDescrWrite(mem, value);
}

41
pcsx2/ps2/pgif.cpp
View File

@ -1017,47 +1017,6 @@ u8 psExp2R8(u32 mem)
//int flgint = 0;
char strb[200] = {0};
void kernelTTYFileDescrWrite(u32 mem, u32 data)
{
//data is an address actually
char stra[100];
int i;
// if (mem == ) {
for (i = 0; i < 100; i++)
stra[i] = iopMemRead8(data + i);
stra[99] = 0;
//Console.WriteLn("Wr to PS1 kernel file TTY descr. data = %08X at addr %08X >%s< ", data, iopMemRead32(data), stra);
//Console.WriteLn("%s", stra);
if ((strlen(strb) + strlen(stra)) >= 200) {
//Console.WriteLn("%s", strb);
strb[0] = 0;
} else {
strcat(strb, stra);
if ((stra[strlen(stra) - 1] == 0xA) || (stra[strlen(stra) - 1] == 0xD) || (stra[strlen(stra) - 2] == 0xA) || (stra[strlen(stra) - 2] == 0xD)) {
// VSync: timeout is spammy
if (strncmp(strb, "VSync: timeout", 14) != 0) {
Console.WriteLn("%s", strb);
/* if (strcmp(strb, "VSync") == 0)
flgint ^= 1;
if (strncmp(strb, "Execute", 5) == 0) {
Console.WriteLn(" ###EXecute was just printed####");
doAnyIopLs = 1;
}*/
}
strb[0] = 0;
}
}
//}
}
//0x80051080
u32 getIntTmrKReg(u32 mem, u32 data)
{