From 096e5e1fefc0a5b631e51a083c20f593f5d65f3b Mon Sep 17 00:00:00 2001 From: Gregory Hainaut Date: Fri, 16 Oct 2015 23:17:07 +0200 Subject: [PATCH] spu2x: correctly apply the volume to the external source CID 147046 (#1 of 1): Useless call (USELESS_CALL) side_effect_free: Calling ApplyVolume(Ext, Cores[1].ExtVol) is only useful for its return value, which is ignored. --- plugins/spu2-x/src/Mixer.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/spu2-x/src/Mixer.cpp b/plugins/spu2-x/src/Mixer.cpp index ba8ebe2ab1..b7799c6b2c 100644 --- a/plugins/spu2-x/src/Mixer.cpp +++ b/plugins/spu2-x/src/Mixer.cpp @@ -860,7 +860,7 @@ void Mix() spu2M_WriteFast( 0xA00 + OutPos, Ext.Right ); WaveDump::WriteCore( 0, CoreSrc_External, Ext ); - ApplyVolume( Ext, Cores[1].ExtVol ); + Ext = ApplyVolume( Ext, Cores[1].ExtVol ); StereoOut32 Out( Cores[1].Mix( VoiceData[1], InputData[1], Ext ) ); if( PlayMode & 8 )