From bfe0ba7e990da50f81666dcc145e5d9dc4702795 Mon Sep 17 00:00:00 2001
From: Tyler Wilding <xtvaser@gmail.com>
Date: Sun, 24 Jan 2021 17:56:12 -0500
Subject: [PATCH] ci: Add an explicit flag to retain Windows debugging
 artifacts

---
 .github/workflows/windows-workflow.yml | 3 +++
 buildbot.xml                           | 5 ++++-
 2 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/.github/workflows/windows-workflow.yml b/.github/workflows/windows-workflow.yml
index b87855bcbf..0a03d684cd 100644
--- a/.github/workflows/windows-workflow.yml
+++ b/.github/workflows/windows-workflow.yml
@@ -65,6 +65,9 @@ jobs:
           vs-version: 16.7
 
       - name: Build PCSX2
+        env:
+          # Set to 'true' to retain the .pdb / .exp / .lib, etc files which can be useful for repro'ing issues that only occur in the compiled .exe
+          RetainDebuggingArtifacts: "false"
         run: msbuild "buildbot.xml" /m /v:n /t:ReleaseAll /p:Platform=${{ matrix.platform }}
 
       - name: Prepare Artifact Metadata
diff --git a/buildbot.xml b/buildbot.xml
index 8cf22b62b2..5093978ccd 100644
--- a/buildbot.xml
+++ b/buildbot.xml
@@ -20,8 +20,11 @@
       CreateHardLinksForPublishFilesIfPossible=$(CreateHardLinksIfPossible);
     </CompileFastPlz>
   </PropertyGroup>
+  <PropertyGroup>
+    <RetainDebuggingArtifacts Condition="'$(RetainDebuggingArtifacts)' == ''">false</RetainDebuggingArtifacts>
+  </PropertyGroup>
   <!-- Add all the custom targets here. -->
-  <Target Name="CleanBloat" AfterTargets="InternalBuild">
+  <Target Name="CleanBloat" AfterTargets="InternalBuild" Condition="'$(RetainDebuggingArtifacts)' == 'false'">
     <ItemGroup>
       <BloatToDelete Include="$(MSBuildProjectDirectory)\bin\**\*.bsc"/>
       <BloatToDelete Include="$(MSBuildProjectDirectory)\bin\**\*.exp"/>