ShuriZma
/
pcsx2
mirror of https://github.com/PCSX2/pcsx2.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

pcsx2:debugger: Fix potential buffer overrun 

CID 146914 (#1 of 1): Copy into fixed size buffer (STRING_OVERFLOW)

The overflow can be triggered using the Debugger's Rename Function
feature.
This commit is contained in:
Jonathan Li 2015-09-13 23:39:35 +01:00
parent 39c5cd4f84
commit b0803a4bc6
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
pcsx2/DebugTools/SymbolMap.cpp
View File

@ -576,8 +576,8 @@ void SymbolMap::SetLabelName(const char* name, u32 address, bool updateImmediate
auto symbolKey = std::make_pair(labelInfo->second.module, labelInfo->second.addr); auto symbolKey = std::make_pair(labelInfo->second.module, labelInfo->second.addr);
auto label = labels.find(symbolKey); auto label = labels.find(symbolKey);
if (label != labels.end()) { if (label != labels.end()) {
strcpy(label->second.name,name); strncpy(label->second.name, name, ARRAY_SIZE(label->second.name));
label->second.name[127] = 0; label->second.name[ARRAY_SIZE(label->second.name) - 1] = 0;
// Allow the caller to skip this as it causes extreme startup slowdown // Allow the caller to skip this as it causes extreme startup slowdown
// when this gets called for every function identified by the function replacement code. // when this gets called for every function identified by the function replacement code.