From b0026ff59f9d92584e79c58c2d07a9461f2a9846 Mon Sep 17 00:00:00 2001 From: Ty Lamontagne Date: Wed, 31 Jul 2024 11:01:14 -0400 Subject: [PATCH] ci: use fromJson to propely compare flatpack and pcsx2 release versions --- .github/workflows/cron_publish_flatpak.yml | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/.github/workflows/cron_publish_flatpak.yml b/.github/workflows/cron_publish_flatpak.yml index 931b986f89..e079235ef6 100644 --- a/.github/workflows/cron_publish_flatpak.yml +++ b/.github/workflows/cron_publish_flatpak.yml @@ -30,7 +30,11 @@ jobs: build: needs: check - if: needs.check.outputs.FLATHUB_RELEASE < needs.check.outputs.PCSX2_RELEASE + # outputs are automatically compared as strings. This doesn't work in our favour + # Use fromJson() to convert them to proper integers... + # see: https://github.com/github/docs/pull/25870 + # and: https://github.com/orgs/community/discussions/57480 + if: fromJson(needs.check.outputs.FLATHUB_RELEASE) < fromJson(needs.check.outputs.PCSX2_RELEASE) name: "Build and publish Flatpak" uses: ./.github/workflows/linux_build_flatpak.yml with: