From ad784a56eca129058953bf641a518a58902b5cca Mon Sep 17 00:00:00 2001 From: refractionpcsx2 Date: Sun, 4 Oct 2015 15:04:34 +0100 Subject: [PATCH] superVU: Fix missing breaks. -This was actually a bug, may improve some games that were buggy in superVU, but these functions aren't often used. -Coverity CID 146865 & 146864: In recVUMI_ESIN(VURegs *, int): Missing break statement between cases in switch statement (CWE-484) -Coverity CID 146863 & 146862: In recVUMI_EEXP(VURegs *, int): Missing break statement between cases in switch statement (CWE-484) -Coverity CID 146855 & 146854: In recVUMI_EATAN(VURegs *, int): Missing break statement between cases in switch statement (CWE-484) --- pcsx2/x86/sVU_Lower.cpp | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/pcsx2/x86/sVU_Lower.cpp b/pcsx2/x86/sVU_Lower.cpp index 391ea7741f..f1100185d3 100644 --- a/pcsx2/x86/sVU_Lower.cpp +++ b/pcsx2/x86/sVU_Lower.cpp @@ -1847,9 +1847,9 @@ void recVUMI_ESIN( VURegs *VU, int info ) //Console.WriteLn("recVUMI_ESIN"); if( (xmmregs[EEREC_S].mode & MODE_WRITE) && (xmmregs[EEREC_S].mode&MODE_NOFLUSH) ) { switch(_Fsf_) { - case 0: SSE_MOVSS_XMM_to_M32((uptr)s_tempmem, EEREC_S); - case 1: SSE_MOVLPS_XMM_to_M64((uptr)s_tempmem, EEREC_S); - default: SSE_MOVHPS_XMM_to_M64((uptr)&s_tempmem[2], EEREC_S); + case 0: SSE_MOVSS_XMM_to_M32((uptr)s_tempmem, EEREC_S); break; + case 1: SSE_MOVLPS_XMM_to_M64((uptr)s_tempmem, EEREC_S); break; + default: SSE_MOVHPS_XMM_to_M64((uptr)&s_tempmem[2], EEREC_S); break; } FLD32((uptr)&s_tempmem[_Fsf_]); } @@ -1878,9 +1878,9 @@ void recVUMI_EATAN( VURegs *VU, int info ) //Console.WriteLn("recVUMI_EATAN"); if( (xmmregs[EEREC_S].mode & MODE_WRITE) && (xmmregs[EEREC_S].mode&MODE_NOFLUSH) ) { switch(_Fsf_) { - case 0: SSE_MOVSS_XMM_to_M32((uptr)s_tempmem, EEREC_S); - case 1: SSE_MOVLPS_XMM_to_M64((uptr)s_tempmem, EEREC_S); - default: SSE_MOVHPS_XMM_to_M64((uptr)&s_tempmem[2], EEREC_S); + case 0: SSE_MOVSS_XMM_to_M32((uptr)s_tempmem, EEREC_S); break; + case 1: SSE_MOVLPS_XMM_to_M64((uptr)s_tempmem, EEREC_S); break; + default: SSE_MOVHPS_XMM_to_M64((uptr)&s_tempmem[2], EEREC_S); break; } FLD32((uptr)&s_tempmem[_Fsf_]); } @@ -1910,9 +1910,9 @@ void recVUMI_EEXP( VURegs *VU, int info ) if( (xmmregs[EEREC_S].mode & MODE_WRITE) && (xmmregs[EEREC_S].mode&MODE_NOFLUSH) ) { switch(_Fsf_) { - case 0: SSE_MOVSS_XMM_to_M32((uptr)s_tempmem, EEREC_S); - case 1: SSE_MOVLPS_XMM_to_M64((uptr)s_tempmem, EEREC_S); - default: SSE_MOVHPS_XMM_to_M64((uptr)&s_tempmem[2], EEREC_S); + case 0: SSE_MOVSS_XMM_to_M32((uptr)s_tempmem, EEREC_S); break; + case 1: SSE_MOVLPS_XMM_to_M64((uptr)s_tempmem, EEREC_S); break; + default: SSE_MOVHPS_XMM_to_M64((uptr)&s_tempmem[2], EEREC_S); break; } FMUL32((uptr)&s_tempmem[_Fsf_]); }