From ac0d7f74cff97c12b200c483298f88a8b223ec09 Mon Sep 17 00:00:00 2001 From: Gregory Hainaut Date: Sun, 27 Dec 2015 11:24:05 +0100 Subject: [PATCH] gsdx: reorder renderer config code & fix linux gui Group all DX option into a unique section (avoid tons of ifdef) Rename Null renderer as "None (Core Benchmark)" --- plugins/GSdx/GSdx.cpp | 24 ++++++++++-------------- 1 file changed, 10 insertions(+), 14 deletions(-) diff --git a/plugins/GSdx/GSdx.cpp b/plugins/GSdx/GSdx.cpp index ada647aedb..9567969ff0 100644 --- a/plugins/GSdx/GSdx.cpp +++ b/plugins/GSdx/GSdx.cpp @@ -129,21 +129,25 @@ GSdxApp::GSdxApp() m_section = "Settings"; #ifdef _WINDOWS - // GPU accelerated options come first m_gs_renderers.push_back(GSSetting(static_cast(GSRendererType::DX9_HW), "Direct3D9", "")); m_gs_renderers.push_back(GSSetting(static_cast(GSRendererType::DX1011_HW), "Direct3D11", "")); -#endif - m_gs_renderers.push_back(GSSetting(static_cast(GSRendererType::OGL_HW), "OpenGL", "")); - // Software renderer variants come second -#ifdef _WINDOWS m_gs_renderers.push_back(GSSetting(static_cast(GSRendererType::DX9_SW), "Software Renderer", "Direct3D9")); m_gs_renderers.push_back(GSSetting(static_cast(GSRendererType::DX1011_SW), "Software Renderer", "Direct3D11")); + +#ifdef _DEBUG + m_gs_renderers.push_back(GSSetting(static_cast(GSRendererType::DX9_Null), "Direct3D9", "Null")); + m_gs_renderers.push_back(GSSetting(static_cast(GSRendererType::DX1011_Null), "Direct3D11", "Null")); + m_gs_renderers.push_back(GSSetting(static_cast(GSRendererType::Null_SW), "Null", "Software")); #endif +#endif + + m_gs_renderers.push_back(GSSetting(static_cast(GSRendererType::OGL_HW), "OpenGL", "")); m_gs_renderers.push_back(GSSetting(static_cast(GSRendererType::OGL_SW), "Software Renderer", "OpenGL")); // The null renderer goes third, it has use for benchmarking purposes in a release build - m_gs_renderers.push_back(GSSetting(static_cast(GSRendererType::Null_Null), "Null", "")); + m_gs_renderers.push_back(GSSetting(static_cast(GSRendererType::Null_Null), "None", "Core Benchmark")); + #ifdef ENABLE_OPENCL // OpenCL stuff goes last // FIXME openCL isn't attached to a device (could be impacted by the window management stuff however) @@ -153,14 +157,6 @@ GSdxApp::GSdxApp() m_gs_renderers.push_back(GSSetting(static_cast(GSRendererType::OGL_OpenCL), "OpenGL", "OpenCL")); #endif -#ifdef _DEBUG - // Every other option gets relegated to debug builds - m_gs_renderers.push_back(GSSetting(static_cast(GSRendererType::DX9_Null), "Direct3D9", "Null")); - m_gs_renderers.push_back(GSSetting(static_cast(GSRendererType::DX1011_Null), "Direct3D11", "Null")); - m_gs_renderers.push_back(GSSetting(static_cast(GSRendererType::Null_SW), "Null", "Software")); - m_gs_renderers.push_back(GSSetting(static_cast(GSRendererType::Null_Null), "Null", "Null")); -#endif - m_gs_interlace.push_back(GSSetting(0, "None", "")); m_gs_interlace.push_back(GSSetting(1, "Weave tff", "saw-tooth")); m_gs_interlace.push_back(GSSetting(2, "Weave bff", "saw-tooth"));