From a1727a2ac750b32b45fc8fed175422933d03203e Mon Sep 17 00:00:00 2001 From: Tyler Wilding Date: Wed, 2 Aug 2023 20:46:56 -0400 Subject: [PATCH] ci: announce release after it's published It's no longer working because workflows will not implicitly trigger from another workflow when initiated by the default token. You must explicitly call them via a `workflow_dispatch` or use a distinct PAT. The announce workflow isn't really used anywhere else so simplifying and consolidating the steps feels appropriate. --- .github/workflows/release_announce.yml | 24 ------------------------ .github/workflows/release_cut_new.yml | 12 ++++++++++++ 2 files changed, 12 insertions(+), 24 deletions(-) delete mode 100644 .github/workflows/release_announce.yml diff --git a/.github/workflows/release_announce.yml b/.github/workflows/release_announce.yml deleted file mode 100644 index 2ab99058f0..0000000000 --- a/.github/workflows/release_announce.yml +++ /dev/null @@ -1,24 +0,0 @@ -name: 📢 Announce Release - -on: - release: - types: [published] - -jobs: - announce: - if: github.repository == 'PCSX2/pcsx2' - runs-on: ubuntu-latest - steps: - - uses: actions/checkout@v3 - - - uses: actions/setup-node@v3 - with: - node-version: 16 - - - name: Announce Release - env: - DISCORD_BUILD_WEBHOOK: ${{ secrets.DISCORD_BUILD_WEBHOOK }} - run: | - cd ./.github/workflows/scripts/releases/announce-release - npm ci - node index.js diff --git a/.github/workflows/release_cut_new.yml b/.github/workflows/release_cut_new.yml index e8dff0a3ad..87841da100 100644 --- a/.github/workflows/release_cut_new.yml +++ b/.github/workflows/release_cut_new.yml @@ -184,3 +184,15 @@ jobs: TAG_VAL=$(git tag --points-at HEAD) echo "TAG_VAL=${TAG_VAL}" gh release edit ${TAG_VAL} --draft=false --repo PCSX2/pcsx2 + + - uses: actions/setup-node@v3 + with: + node-version: 16 + + - name: Announce Release + env: + DISCORD_BUILD_WEBHOOK: ${{ secrets.DISCORD_BUILD_WEBHOOK }} + run: | + cd ./.github/workflows/scripts/releases/announce-release + npm ci + node index.js