Configuration dialog: The 'Apply' button is now disabled when the dialog is opened (was only being disabled after clicking it, rest of the dialogs were behaving ok).

- The automatic disabled Apply on open didn't work for SysConfigDialog because GSWindowPanel and VideoPanel were using SetValue for text boxes when they initialize, which triggered a "SomethingChanged" event (it captures, among others, the wxEVT_COMMAND_TEXT_UPDATED event which is also triggered by SetValue for text boxes). The solution, per wxWindows docs, is to use ChangeValue instead, which doesn't trigger this event.

git-svn-id: http://pcsx2.googlecode.com/svn/trunk@4254 96395faa-99c1-11dd-bbfe-3dabce05a288
This commit is contained in:
avihal@gmail.com 2011-01-23 01:53:01 +00:00
parent f273f6c9b2
commit 9e485b447e
2 changed files with 4 additions and 4 deletions

View File

@ -133,8 +133,8 @@ void Panels::GSWindowSettingsPanel::ApplyConfigToGui( AppConfig& configToApply,
m_check_DclickFullscreen ->SetValue ( conf.IsToggleFullscreenOnDoubleClick ); m_check_DclickFullscreen ->SetValue ( conf.IsToggleFullscreenOnDoubleClick );
m_text_WindowWidth ->SetValue( wxsFormat( L"%d", conf.WindowSize.GetWidth() ) ); m_text_WindowWidth ->ChangeValue( wxsFormat( L"%d", conf.WindowSize.GetWidth() ) );
m_text_WindowHeight ->SetValue( wxsFormat( L"%d", conf.WindowSize.GetHeight() ) ); m_text_WindowHeight ->ChangeValue( wxsFormat( L"%d", conf.WindowSize.GetHeight() ) );
} }
m_check_VsyncEnable->Enable(!configToApply.EnablePresets); m_check_VsyncEnable->Enable(!configToApply.EnablePresets);

View File

@ -129,8 +129,8 @@ void Panels::FramelimiterPanel::ApplyConfigToGui( AppConfig& configToApply, int
m_spin_TurboPct ->SetValue( appfps.TurboScalar.Raw ); m_spin_TurboPct ->SetValue( appfps.TurboScalar.Raw );
m_spin_SlomoPct ->SetValue( appfps.SlomoScalar.Raw ); m_spin_SlomoPct ->SetValue( appfps.SlomoScalar.Raw );
m_text_BaseNtsc ->SetValue( gsconf.FramerateNTSC.ToString() ); m_text_BaseNtsc ->ChangeValue( gsconf.FramerateNTSC.ToString() );
m_text_BasePal ->SetValue( gsconf.FrameratePAL.ToString() ); m_text_BasePal ->ChangeValue( gsconf.FrameratePAL.ToString() );
m_spin_NominalPct ->Enable(!configToApply.EnablePresets); m_spin_NominalPct ->Enable(!configToApply.EnablePresets);
m_spin_TurboPct ->Enable(!configToApply.EnablePresets); m_spin_TurboPct ->Enable(!configToApply.EnablePresets);