ShuriZma
/
pcsx2
mirror of https://github.com/PCSX2/pcsx2.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

GS/TextureReplacements: Use aligned buffer for texture dumping

This commit is contained in:
Connor McLaughlin 2022-05-12 17:25:05 +10:00 committed by refractionpcsx2
parent 221eaf1a81
commit 943b513a52
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
pcsx2/GS/Renderers/HW/GSTextureReplacements.cpp
View File

@ -15,6 +15,7 @@
#include "PrecompiledHeader.h" #include "PrecompiledHeader.h"
#include "common/AlignedMalloc.h"
#include "common/HashCombine.h" #include "common/HashCombine.h"
#include "common/FileSystem.h" #include "common/FileSystem.h"
#include "common/Path.h" #include "common/Path.h"
@ -578,12 +579,13 @@ void GSTextureReplacements::DumpTexture(const GSTextureCache::HashCacheKey& hash
const u32 pitch = static_cast<u32>(read_width) * sizeof(u32); const u32 pitch = static_cast<u32>(read_width) * sizeof(u32);
// use per-texture buffer so we can compress the texture asynchronously and not block the GS thread // use per-texture buffer so we can compress the texture asynchronously and not block the GS thread
std::vector<u8> buffer(pitch * static_cast<u32>(read_height)); // must be 32 byte aligned for ReadTexture().
(mem.*psm.rtx)(mem.GetOffset(TEX0.TBP0, TEX0.TBW, TEX0.PSM), block_rect, buffer.data(), pitch, TEXA); AlignedBuffer<u8, 32> buffer(pitch * static_cast<u32>(read_height));
(mem.*psm.rtx)(mem.GetOffset(TEX0.TBP0, TEX0.TBW, TEX0.PSM), block_rect, buffer.GetPtr(), pitch, TEXA);
// okay, now we can actually dump it // okay, now we can actually dump it
QueueWorkerThreadItem([filename = std::move(filename), tw, th, pitch, buffer = std::move(buffer)]() { QueueWorkerThreadItem([filename = std::move(filename), tw, th, pitch, buffer = std::move(buffer)]() {
if (!SavePNGImage(filename.c_str(), tw, th, buffer.data(), pitch)) if (!SavePNGImage(filename.c_str(), tw, th, buffer.GetPtr(), pitch))
Console.Error("Failed to dump texture to '%s'.", filename.c_str()); Console.Error("Failed to dump texture to '%s'.", filename.c_str());
}); });
} }