ShuriZma
/
pcsx2
mirror of https://github.com/PCSX2/pcsx2.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Counters: Make the code behavior more explicit 

CID 168623 (#1 of 1): Missing break in switch
(MISSING_BREAK)unterminated_case: The case for value
GS_VideoMode::Unknown is not terminated by a 'break' statement.
This commit is contained in:
Akash 2016-08-22 22:11:30 +05:30
parent de32691b4e
commit 7e5bca3dfd
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
pcsx2/Counters.cpp
View File

@ -335,14 +335,13 @@ u32 UpdateVSyncRate()
scanlines = SCANLINES_TOTAL_NTSC; scanlines = SCANLINES_TOTAL_NTSC;
break; break;
// Falls through to unknown when unidentified mode parameter of SetGsCrt is detected.
case GS_VideoMode::Unknown: case GS_VideoMode::Unknown:
default:
// Falls through to default when unidentified mode parameter of SetGsCrt is detected.
// For Release builds, keep using the NTSC timing values when unknown video mode is detected. // For Release builds, keep using the NTSC timing values when unknown video mode is detected.
// Assert will be triggered for debug/dev builds. // Assert will be triggered for debug/dev builds.
scanlines = SCANLINES_TOTAL_NTSC; scanlines = SCANLINES_TOTAL_NTSC;
Console.Error("PCSX2-Counters: Unknown video mode detected"); Console.Error("PCSX2-Counters: Unknown video mode detected");
default:
pxAssertDev(false , "Unknown video mode detected via SetGsCrt"); pxAssertDev(false , "Unknown video mode detected via SetGsCrt");
} }