ShuriZma
/
pcsx2
mirror of https://github.com/PCSX2/pcsx2.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

GS: Only swap DATE_GL42 with DATE_GL45 when full barriers are used 

Saves the expensive draw splitting/barriers when mixed software blending
is used.
This commit is contained in:
Connor McLaughlin 2021-12-30 15:26:44 +10:00 committed by refractionpcsx2
parent 1a8a5a5e8e
commit 73df4e4abf
1 changed files with 14 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
pcsx2/GS/Renderers/HW/GSRendererNew.cpp
View File

@ -661,20 +661,6 @@ void GSRendererNew::EmulateBlending(bool& DATE_GL42, bool& DATE_GL45)
}
}
// GL42 interact very badly with sw blending. GL42 uses the primitiveID to find the primitive
// that write the bad alpha value. Sw blending will force the draw to run primitive by primitive
// (therefore primitiveID will be constant to 1).
// Switch DATE_GL42 with DATE_GL45 in such cases to ensure accuracy.
// No mix of COLCLIP + sw blend + DATE_GL42, neither sw fbmask + DATE_GL42.
// Note: Do the swap after colclip to avoid adding extra conditions.
if (sw_blending && DATE_GL42)
{
GL_PERF("DATE: Swap DATE_GL42 with DATE_GL45");
m_conf.require_full_barrier = true;
DATE_GL42 = false;
DATE_GL45 = true;
}
// For stat to optimize accurate option
#if 0
GL_INS("BLEND_INFO: %d/%d/%d/%d. Clamp:%d. Prim:%d number %d (drawlist %d) (sw %d)",
@ -758,6 +744,20 @@ void GSRendererNew::EmulateBlending(bool& DATE_GL42, bool& DATE_GL45)
m_conf.blend = {blend_index, ALPHA.FIX, ALPHA.C == 2, false, false};
}
}
// GL42 interact very badly with sw blending. GL42 uses the primitiveID to find the primitive
// that write the bad alpha value. Sw blending will force the draw to run primitive by primitive
// (therefore primitiveID will be constant to 1).
// Switch DATE_GL42 with DATE_GL45 in such cases to ensure accuracy.
// No mix of COLCLIP + sw blend + DATE_GL42, neither sw fbmask + DATE_GL42.
// Note: Do the swap in the end, saves the expensive draw splitting/barriers when mixed software blending is used.
if (sw_blending && DATE_GL42 && m_conf.require_full_barrier)
{
GL_PERF("DATE: Swap DATE_GL42 with DATE_GL45");
m_conf.require_full_barrier = true;
DATE_GL42 = false;
DATE_GL45 = true;
}
}
void GSRendererNew::EmulateTextureSampler(const GSTextureCache::Source* tex)