ShuriZma
/
pcsx2
mirror of https://github.com/PCSX2/pcsx2.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Console: Limit buffer size in ConsoleLogFromVM::Write

This commit is contained in:
chaoticgd 2024-11-25 11:48:40 +00:00 committed by lightningterror
parent 5d40f36fa8
commit 719063e996
1 changed files with 12 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
pcsx2/DebugTools/Debug.h
View File

@ -87,8 +87,7 @@ struct ConsoleLog : public LogBase
// ConsoleLogFromVM // ConsoleLogFromVM
// -------------------------------------------------------------------------------------- // --------------------------------------------------------------------------------------
// Special console logger for Virtual Machine log sources, such as the EE and IOP console // Special console logger for Virtual Machine log sources, such as the EE and IOP console
// writes (actual game developer messages and such). These logs do *not* automatically // writes (actual game developer messages and such). These logs do *not* support printf
// append newlines, since the VM generates them manually; and they do *not* support printf
// formatting, since anything coming over the EE/IOP consoles should be considered raw // formatting, since anything coming over the EE/IOP consoles should be considered raw
// string data. (otherwise %'s would get mis-interpreted). // string data. (otherwise %'s would get mis-interpreted).
// //
@ -102,24 +101,20 @@ public:
{ {
for (const char ch : msg) for (const char ch : msg)
{ {
if (ch == '\n') // Ignore control characters.
{ // Otherwise you get fun bells going off.
if (!m_buffer.empty()) if (ch < 0x20)
continue;
if (ch != '\n')
m_buffer.push_back(ch);
if (ch == '\n' || m_buffer.size() >= 4096)
{ {
Console.WriteLn(conColor, m_buffer); Console.WriteLn(conColor, m_buffer);
m_buffer.clear(); m_buffer.clear();
} }
} }
else if (ch < 0x20)
{
// Ignore control characters.
// Otherwise you get fun bells going off.
}
else
{
m_buffer.push_back(ch);
}
}
return false; return false;
} }