Update compiler flags, as a number of plugins didn't have them set. Setting -Wno-parentheses across the board to suppress warnings about gtk from gcc 8.

2018-10-13 11:05:27 -07:00 · 2018-10-13 11:05:27 -07:00 · 70033020a3
parent af646895f4
commit 70033020a3
14 changed files with 77 additions and 18 deletions
--- a/plugins/CDVDnull/CMakeLists.txt
+++ b/plugins/CDVDnull/CMakeLists.txt
@ -8,8 +8,13 @@ endif()

 # plugin name
 set(Output CDVDnull)
-set(CDVDnullFinalFlags "")

+set(CDVDnullFinalFlags
+    -fvisibility=hidden
+    -Wall
+    -Wno-parentheses
+	)
+	
 # CDVDnull sources
 set(CDVDnullSources
 	CDVD.cpp)
--- a/plugins/FWnull/CMakeLists.txt
+++ b/plugins/FWnull/CMakeLists.txt
@ -8,7 +8,12 @@ endif()

 # plugin name
 set(Output FWnull-0.7.0)
-set(FWnullFinalFlags "")
+
+set(FWnullFinalFlags
+    -fvisibility=hidden
+    -Wall
+    -Wno-parentheses
+	)

 # FWnull sources
 set(FWnullSources
--- a/plugins/GSnull/CMakeLists.txt
+++ b/plugins/GSnull/CMakeLists.txt
@ -8,7 +8,12 @@ endif()

 # plugin name
 set(Output GSnull)
-set(GSnullFinalFlags "")
+
+set(GSnullFinalFlags
+    -fvisibility=hidden
+    -Wall
+    -Wno-parentheses
+	)

 # GSnull sources
 set(GSnullSources
--- a/plugins/LilyPad/CMakeLists.txt
+++ b/plugins/LilyPad/CMakeLists.txt
@ -9,8 +9,12 @@ endif()
 # plugin name
 set(Output LilyPad-0.11.0)

-set(lilypadFinalFlags "")
-
+set(lilypadFinalFlags
+    -fvisibility=hidden
+    -Wall
+    -Wno-parentheses
+    )
+    
 # lilypad sources
 set(lilypadSources
    DeviceEnumerator.cpp
--- a/plugins/SPU2null/CMakeLists.txt
+++ b/plugins/SPU2null/CMakeLists.txt
@ -8,8 +8,13 @@ endif()

 # plugin name
 set(Output SPU2null)
-set(SPU2nullFinalFlags "")

+set(SPU2nullFinalFlags
+-fvisibility=hidden
+-Wall
+-Wno-parentheses
+	)
+	
 # SPU2null sources
 set(SPU2nullSources
 	SPU2.cpp)
--- a/plugins/USBnull/CMakeLists.txt
+++ b/plugins/USBnull/CMakeLists.txt
@ -8,7 +8,12 @@ endif()

 # plugin name
 set(Output USBnull-0.7.0)
-set(USBnullFinalFlags "")
+
+set(USBnullFinalFlags
+-fvisibility=hidden
+-Wall
+-Wno-parentheses
+	)

 # USBnull sources
 set(USBnullSources
--- a/plugins/cdvdGigaherz/src/CMakeLists.txt
+++ b/plugins/cdvdGigaherz/src/CMakeLists.txt
@ -8,6 +8,12 @@ endif()
 #plugin name(no version number to ease future version bump and bisect)
 set(Output cdvdGigaherz)

+set(FinalFlags
+    -fvisibility=hidden
+    -Wall
+    -Wno-parentheses
+    )
+
 set(Sources
    CDVD.cpp
    ReadThread.cpp
--- a/plugins/dev9ghzdrk/CMakeLists.txt
+++ b/plugins/dev9ghzdrk/CMakeLists.txt
@ -11,6 +11,7 @@ set(Output dev9ghzdrk-0.4)
 set(CommonFlags
    -fvisibility=hidden
    -Wall
+    -Wno-parentheses
    -I${LIBXML2_INCLUDE_DIR}
    -I${PCAP_INCLUDE_DIR}
    )
--- a/plugins/dev9null/CMakeLists.txt
+++ b/plugins/dev9null/CMakeLists.txt
@ -8,7 +8,12 @@ endif()

 # plugin name
 set(Output dev9null-0.5.0)
-set(dev9nullFinalFlags "")
+
+set(dev9nullFinalFlags
+    -fvisibility=hidden
+    -Wall
+    -Wno-parentheses
+	)

 # dev9null sources
 set(dev9nullSources
--- a/plugins/onepad/CMakeLists.txt
+++ b/plugins/onepad/CMakeLists.txt
@ -40,8 +40,13 @@ set(onepadGuiResources

 # plugin name
 set(Output onepad)
-set(onepadFinalFlags "")

+set(onepadFinalFlags
+    -fvisibility=hidden
+    -Wall
+    -Wno-parentheses
+    )
+    
 # onepad sources
 set(onepadSources
    controller.cpp
--- a/plugins/onepad_legacy/CMakeLists.txt
+++ b/plugins/onepad_legacy/CMakeLists.txt
@ -41,7 +41,12 @@ set(onepadGuiResources

 # plugin name
 set(Output onepad-legacy)
-set(onepadFinalFlags "")
+
+set(onepadFinalFlags
+    -fvisibility=hidden
+    -Wall
+    -Wno-parentheses
+	)

 # onepad sources
 set(onepadSources
--- a/plugins/spu2-x/src/CMakeLists.txt
+++ b/plugins/spu2-x/src/CMakeLists.txt
@ -12,16 +12,22 @@ if(NOT TOP_CMAKE_WAS_SOURCED)
 endif()


+set(CommonFlags
+-fvisibility=hidden
+-Wall
+-Wno-parentheses
+    )
+
 # plugin name
 set(Output spu2x-2.0.0)
 if (UNIX AND NOT APPLE)
 	if (SDL2_API)
-		set(spu2xFinalFlags "-DSPU2X_SDL2")
+		set(spu2xFinalFlags "-DSPU2X_SDL2" ${CommonFlags})
 	else()
-		set(spu2xFinalFlags "-DSPU2X_SDL")
+		set(spu2xFinalFlags "-DSPU2X_SDL" ${CommonFlags})
 	endif()
 else()
-	set(spu2xFinalFlags "")
+	set(spu2xFinalFlags ${CommonFlags})
 endif()

 # spu2x sources
--- a/plugins/zerogs/opengl/CMakeLists.txt
+++ b/plugins/zerogs/opengl/CMakeLists.txt
@ -4,7 +4,8 @@
 set(Output zerogs)

 set(CommonFlags
-    -Wall
+	-Wall
+	-Wno-parentheses
    )

 # Debug - Build
@ -16,13 +17,13 @@ endif(CMAKE_BUILD_TYPE STREQUAL Debug)
 # Devel - Build
 if(CMAKE_BUILD_TYPE STREQUAL Devel)
 	# add defines
-	add_definitions(${CommonFlags})
+	add_definitions(${CommonFlags} -fvisibility=hidden)
 endif(CMAKE_BUILD_TYPE STREQUAL Devel)

 # Release - Build
 if(CMAKE_BUILD_TYPE STREQUAL Release)
 	# add defines
-	add_definitions(${CommonFlags})
+	add_definitions(${CommonFlags} -fvisibility=hidden)
 endif(CMAKE_BUILD_TYPE STREQUAL Release)

 # zerogs sources
--- a/plugins/zzogl-pg/opengl/CMakeLists.txt
+++ b/plugins/zzogl-pg/opengl/CMakeLists.txt
@ -24,6 +24,7 @@ set(CommonFlags
    -fno-strict-aliasing
    -Wstrict-aliasing # Allow to track strict aliasing issue.
    -Wunused-variable
+    -Wno-parentheses
    )

 #Clang doesn't support a few common flags that GCC does.
@ -42,12 +43,12 @@ if(CMAKE_BUILD_TYPE STREQUAL Debug)
 elseif(CMAKE_BUILD_TYPE STREQUAL Devel)
    set(zzoglFinalFlags
        ${zzoglFinalFlags}
-        ${CommonFlags} -g -W -DZEROGS_DEVBUILD
+        ${CommonFlags} -g -W -DZEROGS_DEVBUILD -fvisibility=hidden
    )
 elseif(CMAKE_BUILD_TYPE STREQUAL Release)
    set(zzoglFinalFlags
        ${zzoglFinalFlags}
-        ${CommonFlags} -W
+        ${CommonFlags} -W -fvisibility=hidden
    )
 endif()