GS: Make TC offset changable without recreating

pcsx2-qt/Settings/GraphicsSettingsWidget.ui

@@ -809,7 +809,11 @@
           </widget>
          </item>
          <item>
-          <widget class="QSpinBox" name="textureOffsetX"/>
+          <widget class="QSpinBox" name="textureOffsetX">
+           <property name="maximum">
+            <number>1000</number>
+           </property>
+          </widget>
          </item>
          <item>
           <widget class="QLabel" name="label_18">
@@ -819,7 +823,11 @@
           </widget>
          </item>
          <item>
-          <widget class="QSpinBox" name="textureOffsetY"/>
+          <widget class="QSpinBox" name="textureOffsetY">
+           <property name="maximum">
+            <number>1000</number>
+           </property>
+          </widget>
          </item>
         </layout>
        </item>

pcsx2/GS/GS.cpp

@@ -767,9 +767,6 @@ void GSUpdateConfig(const Pcsx2Config::GSOptions& new_config)
 		GSConfig.SWExtraThreads != old_config.SWExtraThreads ||
 		GSConfig.SWExtraThreadsHeight != old_config.SWExtraThreadsHeight ||
 
-		GSConfig.UserHacks_TCOffsetX != old_config.UserHacks_TCOffsetX ||
-		GSConfig.UserHacks_TCOffsetY != old_config.UserHacks_TCOffsetY ||
-
 		GSConfig.ShadeBoost_Brightness != old_config.ShadeBoost_Brightness ||
 		GSConfig.ShadeBoost_Contrast != old_config.ShadeBoost_Contrast ||
 		GSConfig.ShadeBoost_Saturation != old_config.ShadeBoost_Saturation ||
@@ -793,16 +790,8 @@ void GSUpdateConfig(const Pcsx2Config::GSOptions& new_config)
 		s_gs->SetGameCRC(s_gs->GetGameCRC(), s_gs->GetGameCRCOptions());
 	}
 
-	if (
+	// renderer-specific options (e.g. auto flush, TC offset)
-		GSConfig.AutoFlushSW != old_config.AutoFlushSW ||
+	s_gs->UpdateSettings(old_config);
-		GSConfig.UserHacks_AutoFlush != old_config.UserHacks_AutoFlush ||
-		GSConfig.UserHacks_WildHack != old_config.UserHacks_WildHack)
-	{
-		s_gs->ResetHandlers();
-	}
-
-	if (GSConfig.Mipmap != old_config.Mipmap || GSConfig.HWMipmap != old_config.HWMipmap)
-		s_gs->UpdateMipmapEnabled();
 
 	// reload texture cache when trilinear filtering or TC options change
 	if (

pcsx2/GS/GSState.cpp

@@ -132,7 +132,6 @@ GSState::GSState()
 	Reset();
 
 	ResetHandlers();
-	UpdateMipmapEnabled();
 }
 
 GSState::~GSState()
@@ -315,9 +314,17 @@ void GSState::ResetHandlers()
 	m_fpGIFRegHandlers[GIF_A_D_REG_LABEL] = &GSState::GIFRegHandlerNull;
 }
 
-void GSState::UpdateMipmapEnabled()
+void GSState::UpdateSettings(const Pcsx2Config::GSOptions& old_config)
 {
-	m_mipmap = GSConfig.UseHardwareRenderer() ? (GSConfig.HWMipmap >= HWMipmapLevel::Basic) : GSConfig.Mipmap;
+	m_mipmap = GSConfig.Mipmap;
+
+	if (
+		GSConfig.AutoFlushSW != old_config.AutoFlushSW ||
+		GSConfig.UserHacks_AutoFlush != old_config.UserHacks_AutoFlush ||
+		GSConfig.UserHacks_WildHack != old_config.UserHacks_WildHack)
+	{
+		ResetHandlers();
+	}
 }
 
 bool GSState::isinterlaced()

pcsx2/GS/GSState.h

@@ -260,7 +260,6 @@ public:
 	virtual ~GSState();
 
 	void ResetHandlers();
-	void UpdateMipmapEnabled();
 
 	int GetFramebufferHeight();
 	void SaturateOutputSize(GSVector4i& r);
@@ -274,6 +273,8 @@ public:
 	float GetTvRefreshRate();
 
 	virtual void Reset();
+	virtual void UpdateSettings(const Pcsx2Config::GSOptions& old_config);
+
 	void Flush();
 	void FlushPrim();
 	void FlushWrite();

pcsx2/GS/Renderers/HW/GSRendererHW.cpp

@@ -35,13 +35,7 @@ GSRendererHW::GSRendererHW()
 	, m_lod(GSVector2i(0, 0))
 {
 	m_mipmap = (GSConfig.HWMipmap >= HWMipmapLevel::Basic);
-
+	SetTCOffset();
-	if (GSConfig.UserHacks)
-	{
-		m_userhacks_tcoffset_x           = GSConfig.UserHacks_TCOffsetX / -1000.0f;
-		m_userhacks_tcoffset_y           = GSConfig.UserHacks_TCOffsetY / -1000.0f;
-		m_userhacks_tcoffset             = m_userhacks_tcoffset_x < 0.0f || m_userhacks_tcoffset_y < 0.0f;
-	}
 
 	if (!GSConfig.UpscaleMultiplier) // Custom Resolution
 	{
@@ -158,6 +152,13 @@ void GSRendererHW::CustomResolutionScaling()
 	printf("Frame buffer size set to  %dx%d (%dx%d)\n", scissored_buffer_size.x, scissored_buffer_size.y, m_width, m_height);
 }
 
+void GSRendererHW::SetTCOffset()
+{
+	m_userhacks_tcoffset_x = std::max<s32>(GSConfig.UserHacks_TCOffsetX, 0) / -1000.0f;
+	m_userhacks_tcoffset_y = std::max<s32>(GSConfig.UserHacks_TCOffsetY, 0) / -1000.0f;
+	m_userhacks_tcoffset = m_userhacks_tcoffset_x < 0.0f || m_userhacks_tcoffset_y < 0.0f;
+}
+
 GSRendererHW::~GSRendererHW()
 {
 	delete m_tc;
@@ -215,6 +216,13 @@ void GSRendererHW::Reset()
 	GSRenderer::Reset();
 }
 
+void GSRendererHW::UpdateSettings(const Pcsx2Config::GSOptions& old_config)
+{
+	GSRenderer::UpdateSettings(old_config);
+	m_mipmap = (GSConfig.HWMipmap >= HWMipmapLevel::Basic);
+	SetTCOffset();
+}
+
 void GSRendererHW::VSync(u32 field, bool registers_written)
 {
 	if (m_reset)

pcsx2/GS/Renderers/HW/GSRendererHW.h

@@ -141,6 +141,8 @@ protected:
 
 	virtual void DrawPrims(GSTexture* rt, GSTexture* ds, GSTextureCache::Source* tex) = 0;
 
+	void SetTCOffset();
+
 	bool m_userhacks_tcoffset;
 	float m_userhacks_tcoffset_x;
 	float m_userhacks_tcoffset_y;
@@ -175,6 +177,7 @@ public:
 	GSVector2i GetTargetSize();
 
 	void Reset() override;
+	void UpdateSettings(const Pcsx2Config::GSOptions& old_config) override;
 	void VSync(u32 field, bool registers_written) override;
 
 	GSTexture* GetOutput(int i, int& y_offset) override;