ShuriZma
/
pcsx2
mirror of https://github.com/PCSX2/pcsx2.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

SPU2: Optimize reverb upsampling 

Skip the 0 coefs here as well.
This commit is contained in:
Ziemas 2021-02-17 23:32:28 +01:00 committed by refractionpcsx2
parent 458f22d214
commit 64c526ede2
2 changed files with 17 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
pcsx2/SPU2/Reverb.cpp
View File

@ -112,17 +112,26 @@ s32 __forceinline V_Core::ReverbDownsample(bool right)
} }
StereoOut32 __forceinline V_Core::ReverbUpsample() StereoOut32 __forceinline V_Core::ReverbUpsample(bool phase)
{ {
s32 ls = 0, rs = 0; s32 ls = 0, rs = 0;
for (u32 i = 0; i < NUM_TAPS; i++) if (phase)
{ {
ls += RevbUpBuf[0][((RevbSampleBufPos - NUM_TAPS) + i) & 63] * filter_coefs[i]; ls += RevbUpBuf[0][(((RevbSampleBufPos - NUM_TAPS) >> 1) + 9) & 63] * filter_coefs[19];
rs += RevbUpBuf[1][(((RevbSampleBufPos - NUM_TAPS) >> 1) + 9) & 63] * filter_coefs[19];
} }
for (u32 i = 0; i < NUM_TAPS; i++) else
{ {
rs += RevbUpBuf[1][((RevbSampleBufPos - NUM_TAPS) + i) & 63] * filter_coefs[i];
for (u32 i = 0; i < (NUM_TAPS >> 1) + 1; i++)
{
ls += RevbUpBuf[0][(((RevbSampleBufPos - NUM_TAPS) >> 1) + i) & 63] * filter_coefs[i * 2];
}
for (u32 i = 0; i < (NUM_TAPS >> 1) + 1; i++)
{
rs += RevbUpBuf[1][(((RevbSampleBufPos - NUM_TAPS) >> 1) + i) & 63] * filter_coefs[i * 2];
}
} }
ls >>= 14; ls >>= 14;
@ -223,10 +232,9 @@ StereoOut32 V_Core::DoReverb(const StereoOut32& Input)
_spu2mem[apf2_dst] = clamp_mix(apf2); _spu2mem[apf2_dst] = clamp_mix(apf2);
} }
RevbUpBuf[0][RevbSampleBufPos & 63] = R ? 0 : clamp_mix(out); RevbUpBuf[R][(RevbSampleBufPos >> 1) & 63] = clamp_mix(out);
RevbUpBuf[1][RevbSampleBufPos & 63] = R ? clamp_mix(out) : 0;
RevbSampleBufPos++; RevbSampleBufPos++;
return ReverbUpsample(); return ReverbUpsample(RevbSampleBufPos & 1);
} }

2
pcsx2/SPU2/defs.h
View File

@ -497,7 +497,7 @@ struct V_Core
s32 RevbGetIndexer(s32 offset); s32 RevbGetIndexer(s32 offset);
s32 ReverbDownsample(bool right); s32 ReverbDownsample(bool right);
StereoOut32 ReverbUpsample(); StereoOut32 ReverbUpsample(bool phase);
StereoOut32 ReadInput(); StereoOut32 ReadInput();
StereoOut32 ReadInput_HiFi(); StereoOut32 ReadInput_HiFi();