ShuriZma
/
pcsx2
mirror of https://github.com/PCSX2/pcsx2.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

gsdx-ogl: add some note for the persistent buffer + add a flush 

Persistent is slower (at least on my gs dump) because data is put
in  host instead of the video memory

I don't understand why upload the data directly to the video memory
is faster
This commit is contained in:
Gregory Hainaut 2015-05-14 20:05:49 +02:00
parent 5628bfb20c
commit 613e215c73
1 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
plugins/GSdx/GSTextureOGL.cpp
View File

@ -48,6 +48,14 @@ namespace PboPool {
const GLbitfield map_flags = common_flags | GL_MAP_FLUSH_EXPLICIT_BIT;
const GLbitfield create_flags = common_flags | GL_CLIENT_STORAGE_BIT;
// Perf impact (test was only done on a gs dump):
// Normal (fast): Message:Buffer detailed info: Buffer object 9 (bound to
// GL_PIXEL_UNPACK_BUFFER_ARB, usage hint is GL_STREAM_COPY) will use VIDEO
// memory as the source for buffer object operations.
//
// Persistent (slower): Message:Buffer detailed info: Buffer object 8
// (bound to GL_PIXEL_UNPACK_BUFFER_ARB, usage hint is GL_DYNAMIC_DRAW)
// will use DMA CACHED memory as the source for buffer object operations
void Init() {
gl_GenBuffers(countof(m_pool), m_pool);
m_texture_storage = ((theApp.GetConfig("ogl_texture_storage", 0) == 1) && GLLoader::found_GL_ARB_buffer_storage);
@ -119,9 +127,7 @@ namespace PboPool {
void Unmap() {
if (m_texture_storage) {
// As far as I understand glTexSubImage2D is a client-server transfer so no need to make
// the value visible to the server
//gl_MemoryBarrier(GL_CLIENT_MAPPED_BUFFER_BARRIER_BIT);
gl_FlushMappedBufferRange(GL_PIXEL_UNPACK_BUFFER, m_offset[m_current_pbo], m_size);
} else {
gl_UnmapBuffer(GL_PIXEL_UNPACK_BUFFER);
}