ShuriZma
/
pcsx2
mirror of https://github.com/PCSX2/pcsx2.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Cleaned up some parts of the Multithreaded GS code (MTGS), and made some notes. 

git-svn-id: http://pcsx2-playground.googlecode.com/svn/trunk@341 a6443dda-0b58-4228-96e9-037be469359c
This commit is contained in:
Jake.Stine 2008-11-19 05:56:00 +00:00 committed by Gregory Hainaut
parent 83f0c75dfb
commit 5a5c22e19a
5 changed files with 201 additions and 227 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

149
pcsx2/GS.cpp
View File

@ -122,7 +122,6 @@ u32 g_MTGSDebug = 0, g_MTGSId = 0;
#endif
u32 CSRw;
void gsWaitGS();
extern uptr pDsp;
typedef u8* PU8;
@ -183,6 +182,9 @@ void gsInit()
exit(0);
}
// I guess the InterlockedExchange below is just for practice...
// ... seeing how we haven't even STARTED the thread yet!
memcpy(g_MTGSMem, PS2MEM_GS, sizeof(g_MTGSMem));
InterlockedExchangePointer((volatile PVOID*)&g_pGSWritePos, GS_RINGBUFFERBASE);
@ -223,15 +225,31 @@ void gsInit()
}
}
void gsWaitGS()
__forceinline void gsWaitGS()
{
if( CHECK_DUALCORE ) {
// [Air] : I'm pretty sure there's no harm in doing doing timeslices
// from the main thread in dual-core mode now, thanks to Sleep(0).
// fixme - This may not be true under linux, which uses usleep(500), who's
// behavior likely does not mimic Sleep(0). Ideally the usleep(500) should
// be replaced with something that matches Sleep(0) behavior.
/*if( CHECK_DUALCORE ) {
while( *(volatile PU8*)&g_pGSRingPos != *(volatile PU8*)&g_pGSWritePos );
}
else {
while( g_pGSRingPos != g_pGSWritePos ) {
else {*/
while( *(volatile PU8*)&g_pGSRingPos != *(volatile PU8*)&g_pGSWritePos )
_TIMESLICE();
}
// Sets the gsEvent flag and releases a timeslice.
// For use in loops that wait on the GS thread to do certain things.
static __forceinline void gsSetEventWait()
{
if( !CHECK_DUALCORE ) {
GS_SETEVENT();
_TIMESLICE();
}
}
@ -286,6 +304,11 @@ void gsShutdown()
u8* GSRingBufCopy(void* mem, u32 size, u32 type)
{
// Note on volatiles: g_pGSWritePos is not modified by the GS thread,
// so there's no need to use volatile reads here. We still have to use
// interlocked exchanges when we modify it, however, since the GS thread
// is reading it.
u8* writepos = g_pGSWritePos;
u8* tempbuf;
assert( size < GS_RINGBUFFERSIZE );
@ -299,14 +322,8 @@ u8* GSRingBufCopy(void* mem, u32 size, u32 type)
// skip to beginning
while( writepos < tempbuf || tempbuf == GS_RINGBUFFERBASE ) {
if( !CHECK_DUALCORE ) {
GS_SETEVENT();
_TIMESLICE();
}
gsSetEventWait();
tempbuf = *(volatile PU8*)&g_pGSRingPos;
if( tempbuf == *(volatile PU8*)&g_pGSWritePos )
break;
}
// notify GS
@ -318,25 +335,15 @@ u8* GSRingBufCopy(void* mem, u32 size, u32 type)
writepos = GS_RINGBUFFERBASE;
}
else if( writepos + size == GS_RINGBUFFEREND ) {
while(tempbuf == GS_RINGBUFFERBASE && tempbuf != *(volatile PU8*)&g_pGSWritePos) {
if( !CHECK_DUALCORE ) {
GS_SETEVENT();
_TIMESLICE();
}
while(tempbuf == GS_RINGBUFFERBASE && tempbuf != writepos) {
gsSetEventWait();
tempbuf = *(volatile PU8*)&g_pGSRingPos;
}
}
while( writepos < tempbuf && (writepos+size >= tempbuf || (writepos+size == GS_RINGBUFFEREND && tempbuf == GS_RINGBUFFERBASE)) ) {
if( !CHECK_DUALCORE ) {
GS_SETEVENT();
_TIMESLICE();
}
gsSetEventWait();
tempbuf = *(volatile PU8*)&g_pGSRingPos;
if( tempbuf == *(volatile PU8*)&g_pGSWritePos )
break;
}
// just copy
@ -352,18 +359,9 @@ void GSRingBufSimplePacket(int type, int data0, int data1, int data2)
assert( writepos + 16 <= GS_RINGBUFFEREND );
tempbuf = *(volatile PU8*)&g_pGSRingPos;
if( writepos < tempbuf && writepos+16 >= tempbuf ) {
do {
if( !CHECK_DUALCORE ) {
GS_SETEVENT();
_TIMESLICE();
}
while(writepos < tempbuf && writepos+16 >= tempbuf ) {
gsSetEventWait();
tempbuf = *(volatile PU8*)&g_pGSRingPos;
if( tempbuf == *(volatile PU8*)&g_pGSWritePos )
break;
} while(writepos < tempbuf && writepos+16 >= tempbuf );
}
*(u32*)writepos = type;
@ -374,12 +372,8 @@ void GSRingBufSimplePacket(int type, int data0, int data1, int data2)
writepos += 16;
if( writepos == GS_RINGBUFFEREND ) {
while(tempbuf == GS_RINGBUFFERBASE && tempbuf != *(volatile PU8*)&g_pGSWritePos) {
if( !CHECK_DUALCORE ) {
GS_SETEVENT();
_TIMESLICE();
}
while(tempbuf == GS_RINGBUFFERBASE && tempbuf != g_pGSWritePos) {
gsSetEventWait();
tempbuf = *(volatile PU8*)&g_pGSRingPos;
}
@ -1429,8 +1423,6 @@ void* GSThreadProc(void* lpParam)
#endif
SysPrintf("Starting GS thread\n");
u8* writepos;
u32 tag;
u32 counter = 0;
while(!gsHasToExit) {
@ -1459,23 +1451,26 @@ void* GSThreadProc(void* lpParam)
}
#endif
if( g_pGSRingPos != g_pGSWritePos ) {
do {
writepos = *(volatile PU8*)&g_pGSWritePos;
while( g_pGSRingPos != writepos ) {
// note: gsRingPos is intentionally not volatile, because it should only
// ever be modified by this thread.
while( g_pGSRingPos != *(volatile PU8*)&g_pGSWritePos)
{
assert( g_pGSRingPos < GS_RINGBUFFEREND );
// process until writepos
tag = *(u32*)g_pGSRingPos;
switch( tag&0xffff ) {
u32 tag = *(u32*)g_pGSRingPos;
u32 ringposinc = 16;
switch( tag&0xffff )
{
case GS_RINGTYPE_RESTART:
InterlockedExchangePointer((volatile PVOID*)&g_pGSRingPos, GS_RINGBUFFERBASE);
if( GS_RINGBUFFERBASE == writepos )
goto ExitGS;
/*if( GS_RINGBUFFERBASE == writepos )
{
// force the loop to break:
writepos = g_pGSRingPos;
break;
}*/
continue;
@ -1485,45 +1480,39 @@ void* GSThreadProc(void* lpParam)
// MTGS_RECREAD(g_pGSRingPos+16, (qsize<<4));
// make sure that tag>>16 is the MAX size readable
GSgifTransfer1((u32*)(g_pGSRingPos+16) - 0x1000 + 4*qsize, 0x4000-qsize*16);
InterlockedExchangeAdd((long*)&g_pGSRingPos, 16 + ((tag>>16)<<4));
ringposinc += qsize<<4;
break;
}
case GS_RINGTYPE_P2:
// MTGS_RECREAD(g_pGSRingPos+16, ((tag>>16)<<4));
GSgifTransfer2((u32*)(g_pGSRingPos+16), tag>>16);
InterlockedExchangeAdd((long*)&g_pGSRingPos, 16 + ((tag>>16)<<4));
ringposinc += (tag>>16)<<4;
break;
case GS_RINGTYPE_P3:
// MTGS_RECREAD(g_pGSRingPos+16, ((tag>>16)<<4));
GSgifTransfer3((u32*)(g_pGSRingPos+16), tag>>16);
InterlockedExchangeAdd((long*)&g_pGSRingPos, 16 + ((tag>>16)<<4));
ringposinc += (tag>>16)<<4;
break;
case GS_RINGTYPE_VSYNC:
GSvsync(*(int*)(g_pGSRingPos+4));
if( PAD1update != NULL ) PAD1update(0);
if( PAD2update != NULL ) PAD2update(1);
InterlockedExchangeAdd((long*)&g_pGSRingPos, 16);
break;
case GS_RINGTYPE_FRAMESKIP:
GSsetFrameSkip(*(int*)(g_pGSRingPos+4));
InterlockedExchangeAdd((long*)&g_pGSRingPos, 16);
break;
case GS_RINGTYPE_MEMWRITE8:
g_MTGSMem[*(int*)(g_pGSRingPos+4)] = *(u8*)(g_pGSRingPos+8);
InterlockedExchangeAdd((long*)&g_pGSRingPos, 16);
break;
case GS_RINGTYPE_MEMWRITE16:
*(u16*)(g_MTGSMem+*(int*)(g_pGSRingPos+4)) = *(u16*)(g_pGSRingPos+8);
InterlockedExchangeAdd((long*)&g_pGSRingPos, 16);
break;
case GS_RINGTYPE_MEMWRITE32:
*(u32*)(g_MTGSMem+*(int*)(g_pGSRingPos+4)) = *(u32*)(g_pGSRingPos+8);
InterlockedExchangeAdd((long*)&g_pGSRingPos, 16);
break;
case GS_RINGTYPE_MEMWRITE64:
*(u64*)(g_MTGSMem+*(int*)(g_pGSRingPos+4)) = *(u64*)(g_pGSRingPos+8);
InterlockedExchangeAdd((long*)&g_pGSRingPos, 16);
break;
case GS_RINGTYPE_VIFFIFO:
@ -1537,7 +1526,7 @@ void* GSThreadProc(void* lpParam)
if (pMem == NULL) {
psHu32(DMAC_STAT)|= 1<<15;
break;
continue; // don't increment gsRingPos
}
if( GSreadFIFO2 == NULL ) {
@ -1564,10 +1553,12 @@ void* GSThreadProc(void* lpParam)
vif1ch->madr += vif1ch->qwc * 16;
if(vif1Regs->mskpath3 == 0)vif1Regs->stat&= ~0x1f000000;
// fixme : calling CPU_INT could create a race condition if it runs parallel
// with the EE/IOP code also calling CPU_INT.
CPU_INT(1, 0); // since gs thread always lags real thread
vif1ch->qwc = 0;
InterlockedExchangeAdd((long*)&g_pGSRingPos, 16);
break;
}
@ -1578,18 +1569,15 @@ void* GSThreadProc(void* lpParam)
if (GSfreeze(FREEZE_SIZE, &fP) == -1) {
gzclose(f);
InterlockedExchangeAdd((long*)&g_pGSRingPos, 16);
break;
}
fP.data = (s8*)malloc(fP.size);
if (fP.data == NULL) {
InterlockedExchangeAdd((long*)&g_pGSRingPos, 16);
break;
}
if (GSfreeze(FREEZE_SAVE, &fP) == -1) {
gzclose(f);
InterlockedExchangeAdd((long*)&g_pGSRingPos, 16);
break;
}
@ -1598,8 +1586,6 @@ void* GSThreadProc(void* lpParam)
gzwrite(f, fP.data, fP.size);
free(fP.data);
}
InterlockedExchangeAdd((long*)&g_pGSRingPos, 16);
break;
}
case GS_RINGTYPE_LOAD:
@ -1610,10 +1596,8 @@ void* GSThreadProc(void* lpParam)
gzread(f, &fP.size, sizeof(fP.size));
if (fP.size) {
fP.data = (s8*)malloc(fP.size);
if (fP.data == NULL) {
InterlockedExchangeAdd((long*)&g_pGSRingPos, 16);
if (fP.data == NULL)
break;
}
gzread(f, fP.data, fP.size);
}
@ -1623,7 +1607,6 @@ void* GSThreadProc(void* lpParam)
if (fP.size)
free(fP.data);
InterlockedExchangeAdd((long*)&g_pGSRingPos, 16);
break;
}
case GS_RINGTYPE_RECORD:
@ -1631,28 +1614,22 @@ void* GSThreadProc(void* lpParam)
int record = *(int*)(g_pGSRingPos+4);
if( GSsetupRecording != NULL ) GSsetupRecording(record, NULL);
if( SPU2setupRecording != NULL ) SPU2setupRecording(record, NULL);
InterlockedExchangeAdd((long*)&g_pGSRingPos, 16);
break;
}
default:
SysPrintf("GSThreadProc, bad packet writepos: %x g_pGSRingPos: %x, g_pGSWritePos: %x\n", writepos, g_pGSRingPos, g_pGSWritePos);
SysPrintf("GSThreadProc, bad packet (%x) at g_pGSRingPos: %x, g_pGSWritePos: %x\n", tag, g_pGSRingPos, g_pGSWritePos);
assert(0);
g_pGSRingPos = g_pGSWritePos;
continue;
//flushall();
}
InterlockedExchangeAdd( (long*)&g_pGSRingPos, ringposinc );
assert( g_pGSRingPos <= GS_RINGBUFFEREND );
if( g_pGSRingPos == GS_RINGBUFFEREND )
InterlockedExchangePointer((volatile PVOID*)&g_pGSRingPos, GS_RINGBUFFERBASE);
if( g_pGSRingPos == g_pGSWritePos ) {
break;
}
}
ExitGS:
;
} while(g_pGSRingPos != *(volatile PU8*)&g_pGSWritePos);
}
// process vu1

2
pcsx2/GS.h
View File

@ -125,6 +125,8 @@ void gsInit();
void gsShutdown();
void gsReset();
extern void gsWaitGS();
// used for resetting GIF fifo
void gsGIFReset();

2
pcsx2/Misc.c
View File

@ -456,8 +456,6 @@ const char Pcsx2Header[32] = STATE_VERSION " PCSX2 v" PCSX2_VERSION;
if (fP.size) free(fP.data);
extern void gsWaitGS();
int SaveState(const char *file) {
gzFile f;

2
pcsx2/Plugins.c
View File

@ -634,8 +634,6 @@ OpenError:
return -1;
}
extern void gsWaitGS();
void ClosePlugins()
{
gsWaitGS();

1
pcsx2/VifDma.c
View File

@ -2232,7 +2232,6 @@ __forceinline void vif1Interrupt() {
cpuRegs.interrupt &= ~(1 << 1);
}
extern void gsWaitGS();
extern u32 g_MTGSVifStart, g_MTGSVifCount;
#define spr0 ((DMACh*)&PS2MEM_HW[0xD000])
void dmaVIF1()