ShuriZma
/
pcsx2
mirror of https://github.com/PCSX2/pcsx2.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Change the x86emitter jmp emitter from using s32 to sptr. 

This doesn't change anything on x86_32, but it is required on x86_64 so we don't lose precision.
Also adds an assert to see if the distance is greater than the maximum 32bit jump, which can't be hit on x86_32, but can be on x86_64.
This commit is contained in:
Ryan Houdek 2014-07-15 15:13:15 -05:00
parent 69f57351b2
commit 5114b37bfa
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
common/src/x86emitter/jmp.cpp
View File

@ -126,7 +126,12 @@ __emitinline void xJccKnownTarget( JccComparisonType comparison, const void* tar
{ {
// Perform a 32 bit jump instead. :( // Perform a 32 bit jump instead. :(
s32* bah = xJcc32( comparison ); s32* bah = xJcc32( comparison );
*bah = (s32)target - (s32)xGetPtr(); sptr distance = (sptr)target - (sptr)xGetPtr();
// This assert won't physically happen on x86 targets
pxAssertDev(distance >= -0x80000000LL && distance < 0x80000000LL, "Jump target is too far away, needs an indirect register");
*bah = (s32)distance;
} }
} }