From 4a056fe55a7b52beb4888827b12a00953c4d3acc Mon Sep 17 00:00:00 2001 From: refractionpcsx2 Date: Sun, 4 Oct 2015 14:34:46 +0100 Subject: [PATCH] VIF Unpack: Remove logically dead (and pointless) code -Coverity CID 146829: In nVifUnpack<1>(unsigned char const*): Code can never be reached because of a logical contradiction (CWE-561) --- pcsx2/x86/newVif_Unpack.cpp | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/pcsx2/x86/newVif_Unpack.cpp b/pcsx2/x86/newVif_Unpack.cpp index 1bd12272f1..4359904b87 100644 --- a/pcsx2/x86/newVif_Unpack.cpp +++ b/pcsx2/x86/newVif_Unpack.cpp @@ -164,14 +164,8 @@ _vifT int nVifUnpack(const u8* data) { --vifRegs.num; ++vif.cl; - if (isFill) { - if (vif.cl <= vifRegs.cycle.cl) size -= vSize; - else if (vif.cl == vifRegs.cycle.wl) vif.cl = 0; - } - else { - size -= vSize; - if (vif.cl >= vifRegs.cycle.wl) vif.cl = 0; - } + if (vif.cl <= vifRegs.cycle.cl) size -= vSize; + else if (vif.cl == vifRegs.cycle.wl) vif.cl = 0; } DevCon.Warning("Fill!! Partial num left = %x, guessed %x", vifRegs.num, guessedsize); }