From 47545e511d33d31faf5443a94c16142e6ef777ab Mon Sep 17 00:00:00 2001 From: lightningterror <18107717+lightningterror@users.noreply.github.com> Date: Fri, 8 Dec 2023 13:25:36 +0100 Subject: [PATCH] DEV9: Fix Function parameter should be passed by const reference warnings Codacy. --- pcsx2/DEV9/PacketReader/IP/UDP/DNS/DNS_Classes.cpp | 2 +- pcsx2/DEV9/PacketReader/IP/UDP/DNS/DNS_Classes.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/pcsx2/DEV9/PacketReader/IP/UDP/DNS/DNS_Classes.cpp b/pcsx2/DEV9/PacketReader/IP/UDP/DNS/DNS_Classes.cpp index dbcbf33187..42d1b724a1 100644 --- a/pcsx2/DEV9/PacketReader/IP/UDP/DNS/DNS_Classes.cpp +++ b/pcsx2/DEV9/PacketReader/IP/UDP/DNS/DNS_Classes.cpp @@ -71,7 +71,7 @@ namespace PacketReader::IP::UDP::DNS //null char *offset += 1; } - void DNS_QuestionEntry::WriteDNS_String(u8* buffer, int* offset, std::string value) + void DNS_QuestionEntry::WriteDNS_String(u8* buffer, int* offset, const std::string& value) { int segmentLength = 0; int segmentStart = 0; diff --git a/pcsx2/DEV9/PacketReader/IP/UDP/DNS/DNS_Classes.h b/pcsx2/DEV9/PacketReader/IP/UDP/DNS/DNS_Classes.h index 7a80999666..d22608db59 100644 --- a/pcsx2/DEV9/PacketReader/IP/UDP/DNS/DNS_Classes.h +++ b/pcsx2/DEV9/PacketReader/IP/UDP/DNS/DNS_Classes.h @@ -36,7 +36,7 @@ namespace PacketReader::IP::UDP::DNS private: void ReadDNS_String(u8* buffer, int* offset, std::string* value); - void WriteDNS_String(u8* buffer, int* offset, std::string value); + void WriteDNS_String(u8* buffer, int* offset, const std::string& value); }; class DNS_ResponseEntry : public DNS_QuestionEntry