ShuriZma
/
pcsx2
mirror of https://github.com/PCSX2/pcsx2.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[Soft-Float] - Fixes add/sub edge cases for denormals handling. 

This commit fixup a calculation mistake in add/sub when dealing with booth numbers that are denormals.
This commit is contained in:
GitHubProUser67 2025-06-09 21:32:35 +02:00
parent 7a5ed1502f
commit 44280dd58d
1 changed files with 16 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

38
pcsx2/PS2Float.cpp
View File

@ -185,7 +185,14 @@ PS2Float PS2Float::Add(PS2Float addend)
else if (!IsDenormalized() && addend.IsDenormalized())
return PS2Float(sign, Exponent(), Mantissa());
else if (IsDenormalized() && addend.IsDenormalized())
return PS2Float(sign, 0, 0);
{
if (!Sign() || !addend.Sign())
return PS2Float(false, 0, 0);
else if (Sign() && addend.Sign())
return PS2Float(true, 0, 0);
else
Console.Error("Unhandled addition operation flags");
}
else
Console.Error("Both numbers are not denormalized");
@ -227,7 +234,14 @@ PS2Float PS2Float::Sub(PS2Float subtrahend)
else if (!IsDenormalized() && subtrahend.IsDenormalized())
return PS2Float(sign, Exponent(), Mantissa());
else if (IsDenormalized() && subtrahend.IsDenormalized())
return PS2Float(sign, 0, 0);
{
if (!Sign() || subtrahend.Sign())
return PS2Float(false, 0, 0);
else if (Sign() && !subtrahend.Sign())
return PS2Float(true, 0, 0);
else
Console.Error("Unhandled subtraction operation flags");
}
else
Console.Error("Both numbers are not denormalized");
@ -883,31 +897,11 @@ bool PS2Float::DetermineMultiplicationDivisionOperationSign(PS2Float a, PS2Float
bool PS2Float::DetermineAdditionOperationSign(PS2Float a, PS2Float b)
{
if (a.IsZero() && b.IsZero())
{
if (!a.Sign() || !b.Sign())
return false;
else if (a.Sign() && b.Sign())
return true;
else
Console.Error("Unhandled addition operation flags");
}
return a.CompareOperands(b) >= 0 ? a.Sign() : b.Sign();
}
bool PS2Float::DetermineSubtractionOperationSign(PS2Float a, PS2Float b)
{
if (a.IsZero() && b.IsZero())
{
if (!a.Sign() || b.Sign())
return false;
else if (a.Sign() && !b.Sign())
return true;
else
Console.Error("Unhandled subtraction operation flags");
}
return a.CompareOperands(b) >= 0 ? a.Sign() : !b.Sign();
}