From 42e4a47bfc9ce2854cc4c60d2a4e39503cf0101b Mon Sep 17 00:00:00 2001
From: chaoticgd <43898262+chaoticgd@users.noreply.github.com>
Date: Wed, 28 Aug 2024 00:25:55 +0100
Subject: [PATCH] DebugTools: Fix some compiler warnings

---
 pcsx2-qt/Debugger/Models/BreakpointModel.cpp |  2 --
 pcsx2/DebugTools/DebugInterface.cpp          |  4 ++--
 pcsx2/DebugTools/SymbolGuardian.cpp          | 17 ++---------------
 pcsx2/DebugTools/SymbolGuardian.h            |  4 ----
 4 files changed, 4 insertions(+), 23 deletions(-)

diff --git a/pcsx2-qt/Debugger/Models/BreakpointModel.cpp b/pcsx2-qt/Debugger/Models/BreakpointModel.cpp
index a3e76438cf..07bb9bb898 100644
--- a/pcsx2-qt/Debugger/Models/BreakpointModel.cpp
+++ b/pcsx2-qt/Debugger/Models/BreakpointModel.cpp
@@ -254,8 +254,6 @@ QVariant BreakpointModel::headerData(int section, Qt::Orientation orientation, i
 
 Qt::ItemFlags BreakpointModel::flags(const QModelIndex& index) const
 {
-	volatile const int row = index.row();
-
 	switch (index.column())
 	{
 		case BreakpointColumns::CONDITION:
diff --git a/pcsx2/DebugTools/DebugInterface.cpp b/pcsx2/DebugTools/DebugInterface.cpp
index 90768d476f..f3087cf7a8 100644
--- a/pcsx2/DebugTools/DebugInterface.cpp
+++ b/pcsx2/DebugTools/DebugInterface.cpp
@@ -299,13 +299,13 @@ std::optional<u32> DebugInterface::getStackFrameSize(const ccc::Function& functi
 		u32 instruction = read32(function.address().value);
 
 		if ((instruction & 0xffff0000) == 0x27bd0000)
-			stack_frame_size = -(instruction & 0xffff);
+			stack_frame_size = -static_cast<s16>(instruction & 0xffff);
 
 		if (stack_frame_size < 0)
 			return std::nullopt;
 	}
 
-	return (u32)stack_frame_size;
+	return static_cast<u32>(stack_frame_size);
 }
 
 bool DebugInterface::initExpression(const char* exp, PostfixExpression& dest)
diff --git a/pcsx2/DebugTools/SymbolGuardian.cpp b/pcsx2/DebugTools/SymbolGuardian.cpp
index 7b8624d66b..d959965f4b 100644
--- a/pcsx2/DebugTools/SymbolGuardian.cpp
+++ b/pcsx2/DebugTools/SymbolGuardian.cpp
@@ -3,7 +3,6 @@
 
 #include "SymbolGuardian.h"
 
-#include <demangle.h>
 #include <ccc/ast.h>
 #include <ccc/elf.h>
 #include <ccc/importer_flags.h>
@@ -19,6 +18,8 @@
 #include "Host.h"
 #include "VMManager.h"
 
+#include <demangle.h>
+
 SymbolGuardian R5900SymbolGuardian;
 SymbolGuardian R3000SymbolGuardian;
 
@@ -124,20 +125,6 @@ void SymbolGuardian::Reset()
 	});
 }
 
-static void CreateBuiltInDataType(
-	ccc::SymbolDatabase& database, ccc::SymbolSourceHandle source, const char* name, ccc::ast::BuiltInClass bclass)
-{
-	ccc::Result<ccc::DataType*> symbol = database.data_types.create_symbol(name, source, nullptr);
-	if (!symbol.success())
-		return;
-
-	std::unique_ptr<ccc::ast::BuiltIn> type = std::make_unique<ccc::ast::BuiltIn>();
-	type->name = name;
-	type->size_bytes = ccc::ast::builtin_class_size(bclass);
-	type->bclass = bclass;
-	(*symbol)->set_type(std::move(type));
-}
-
 void SymbolGuardian::ImportElf(std::vector<u8> elf, std::string elf_file_name, const std::string& nocash_path)
 {
 	ccc::Result<ccc::ElfFile> parsed_elf = ccc::ElfFile::parse(std::move(elf));
diff --git a/pcsx2/DebugTools/SymbolGuardian.h b/pcsx2/DebugTools/SymbolGuardian.h
index e1d165b7cb..7959a0707e 100644
--- a/pcsx2/DebugTools/SymbolGuardian.h
+++ b/pcsx2/DebugTools/SymbolGuardian.h
@@ -3,7 +3,6 @@
 
 #pragma once
 
-#include <queue>
 #include <atomic>
 #include <thread>
 #include <functional>
@@ -103,9 +102,6 @@ protected:
 
 	std::thread m_import_thread;
 	std::atomic_bool m_interrupt_import_thread = false;
-
-	std::queue<ccc::SymbolDatabase> m_load_queue;
-	std::mutex m_load_queue_lock;
 };
 
 extern SymbolGuardian R5900SymbolGuardian;