ShuriZma
/
pcsx2
mirror of https://github.com/PCSX2/pcsx2.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

DEV9: Fix function parameter should be passed by const reference warnings. 

Codacy.
This commit is contained in:
lightningterror 2024-06-30 17:18:53 +02:00
parent bed31d3903
commit 3f952c88a4
2 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
pcsx2/DEV9/PacketReader/IP/UDP/DHCP/DHCP_Options.cpp
View File

@ -66,7 +66,7 @@ namespace PacketReader::IP::UDP::DHCP
NetLib::WriteByteArray(buffer, offset, dnsServers.size() * 4, (u8*)&dnsServers[0]); NetLib::WriteByteArray(buffer, offset, dnsServers.size() * 4, (u8*)&dnsServers[0]);
} }
DHCPopHostName::DHCPopHostName(std::string name) DHCPopHostName::DHCPopHostName(const std::string& name)
{ {
if (name.size() > 255) if (name.size() > 255)
{ {
@ -298,7 +298,7 @@ namespace PacketReader::IP::UDP::DHCP
NetLib::WriteByteArray(buffer, offset, requests.size(), &requests[0]); NetLib::WriteByteArray(buffer, offset, requests.size(), &requests[0]);
} }
DHCPopMSGStr::DHCPopMSGStr(std::string msg) DHCPopMSGStr::DHCPopMSGStr(const std::string& msg)
{ {
if (msg.size() > 255) if (msg.size() > 255)
{ {
@ -375,7 +375,7 @@ namespace PacketReader::IP::UDP::DHCP
NetLib::WriteUInt32(buffer, offset, ipRebindingTimeT2); NetLib::WriteUInt32(buffer, offset, ipRebindingTimeT2);
} }
DHCPopClassID::DHCPopClassID(std::string id) DHCPopClassID::DHCPopClassID(const std::string& id)
{ {
if (id.size() > 255) if (id.size() > 255)
{ {

6
pcsx2/DEV9/PacketReader/IP/UDP/DHCP/DHCP_Options.h
View File

@ -90,7 +90,7 @@ namespace PacketReader::IP::UDP::DHCP
//ASCII encoding //ASCII encoding
std::string hostName; std::string hostName;
DHCPopHostName(std::string name); DHCPopHostName(const std::string& name);
DHCPopHostName(u8* data, int offset); //Offset will include Kind and Len DHCPopHostName(u8* data, int offset); //Offset will include Kind and Len
virtual u8 GetLength() { return 2 + hostName.size(); } virtual u8 GetLength() { return 2 + hostName.size(); }
@ -276,7 +276,7 @@ namespace PacketReader::IP::UDP::DHCP
//ASCII encoding //ASCII encoding
std::string message; std::string message;
DHCPopMSGStr(std::string msg); DHCPopMSGStr(const std::string& msg);
DHCPopMSGStr(u8* data, int offset); //Offset will include Kind and Len DHCPopMSGStr(u8* data, int offset); //Offset will include Kind and Len
virtual u8 GetLength() { return 2 + message.size(); } virtual u8 GetLength() { return 2 + message.size(); }
@ -353,7 +353,7 @@ namespace PacketReader::IP::UDP::DHCP
//ASCII encoding //ASCII encoding
std::string classID; std::string classID;
DHCPopClassID(std::string id); DHCPopClassID(const std::string& id);
DHCPopClassID(u8* data, int offset); //Offset will include Kind and Len DHCPopClassID(u8* data, int offset); //Offset will include Kind and Len
virtual u8 GetLength() { return 2 + classID.size(); } virtual u8 GetLength() { return 2 + classID.size(); }