diff --git a/pcsx2-qt/Settings/GraphicsSettingsWidget.cpp b/pcsx2-qt/Settings/GraphicsSettingsWidget.cpp index 502d8127c0..3d6dd0c10f 100644 --- a/pcsx2-qt/Settings/GraphicsSettingsWidget.cpp +++ b/pcsx2-qt/Settings/GraphicsSettingsWidget.cpp @@ -86,6 +86,12 @@ GraphicsSettingsWidget::GraphicsSettingsWidget(SettingsDialog* dialog, QWidget* m_ui.setupUi(this); + // start hidden, fixup in updateRendererDependentOptions() + m_ui.hardwareRendererGroup->setVisible(false); + m_ui.verticalLayout->removeWidget(m_ui.hardwareRendererGroup); + m_ui.softwareRendererGroup->setVisible(false); + m_ui.verticalLayout->removeWidget(m_ui.softwareRendererGroup); + ////////////////////////////////////////////////////////////////////////// // Global Settings ////////////////////////////////////////////////////////////////////////// @@ -209,6 +215,8 @@ GraphicsSettingsWidget::GraphicsSettingsWidget(SettingsDialog* dialog, QWidget* SettingWidgetBinder::BindWidgetToBoolSetting(sif, m_ui.loadTextureReplacements, "EmuCore/GS", "LoadTextureReplacements", false); SettingWidgetBinder::BindWidgetToBoolSetting(sif, m_ui.loadTextureReplacementsAsync, "EmuCore/GS", "LoadTextureReplacementsAsync", true); SettingWidgetBinder::BindWidgetToBoolSetting(sif, m_ui.precacheTextureReplacements, "EmuCore/GS", "PrecacheTextureReplacements", false); + SettingWidgetBinder::BindWidgetToFolderSetting(sif, m_ui.texturesDirectory, m_ui.texturesBrowse, m_ui.texturesOpen, m_ui.texturesReset, + "Folders", "Textures", "textures"); ////////////////////////////////////////////////////////////////////////// // Advanced Settings @@ -538,7 +546,7 @@ void GraphicsSettingsWidget::updateRendererDependentOptions() const int current_tab = m_hardware_renderer_visible ? m_ui.hardwareRendererGroup->currentIndex() : m_ui.softwareRendererGroup->currentIndex(); // move advanced tab to the correct parent - static constexpr std::array move_tab_names = {{"Display", "On-Screen Display", "Advanced"}}; + static constexpr std::array move_tab_names = {{"Display", "OSD", "Advanced"}}; const std::array move_tab_pointers = {{m_ui.gameDisplayTab, m_ui.osdTab, m_ui.advancedTab}}; for (size_t i = 0; i < move_tab_pointers.size(); i++) { @@ -565,7 +573,7 @@ void GraphicsSettingsWidget::updateRendererDependentOptions() { // map first two tabs over, skip hacks m_ui.verticalLayout->insertWidget(1, m_ui.hardwareRendererGroup); - m_ui.hardwareRendererGroup->setCurrentIndex((current_tab < 2) ? current_tab : (current_tab + 2)); + m_ui.hardwareRendererGroup->setCurrentIndex((current_tab < 2) ? current_tab : (current_tab + 3)); } m_hardware_renderer_visible = is_hardware; @@ -685,5 +693,6 @@ void GraphicsSettingsWidget::updateRendererDependentOptions() } m_ui.enableHWFixes->setEnabled(is_hardware); - onEnableHardwareFixesChanged(); + if (is_hardware) + onEnableHardwareFixesChanged(); } diff --git a/pcsx2-qt/Settings/GraphicsSettingsWidget.h b/pcsx2-qt/Settings/GraphicsSettingsWidget.h index 0026fc0a30..5521505742 100644 --- a/pcsx2-qt/Settings/GraphicsSettingsWidget.h +++ b/pcsx2-qt/Settings/GraphicsSettingsWidget.h @@ -31,8 +31,6 @@ public: GraphicsSettingsWidget(SettingsDialog* dialog, QWidget* parent); ~GraphicsSettingsWidget(); - void updateRendererDependentOptions(); - Q_SIGNALS: void fullscreenModesChanged(const QStringList& modes); @@ -48,11 +46,12 @@ private Q_SLOTS: private: GSRendererType getEffectiveRenderer() const; + void updateRendererDependentOptions(); SettingsDialog* m_dialog; Ui::GraphicsSettingsWidget m_ui; - bool m_hardware_renderer_visible = true; - bool m_software_renderer_visible = true; + bool m_hardware_renderer_visible = false; + bool m_software_renderer_visible = false; }; diff --git a/pcsx2-qt/Settings/GraphicsSettingsWidget.ui b/pcsx2-qt/Settings/GraphicsSettingsWidget.ui index 5a0085f1de..46aa3a5311 100644 --- a/pcsx2-qt/Settings/GraphicsSettingsWidget.ui +++ b/pcsx2-qt/Settings/GraphicsSettingsWidget.ui @@ -6,7 +6,7 @@ 0 0 - 566 + 657 890 @@ -913,9 +913,120 @@ + + + Texture Replacement + + + + + + Search Directory + + + + + + + + + Browse... + + + + + + + Open... + + + + + + + Reset + + + + + + + PCSX2 will dump and load texture replacements from this directory. + + + + + + + + + + Options + + + + + + Dump Textures + + + + + + + Dump Mipmaps + + + + + + + Dump FMV Textures + + + + + + + Async Texture Loading + + + + + + + Load Textures + + + + + + + Precache Textures + + + + + + + + + + Qt::Vertical + + + + 20 + 40 + + + + + + - On-Screen Display + OSD @@ -1287,57 +1398,6 @@ - - - - Texture Replacement - - - - - - Dump Textures - - - - - - - Dump Mipmaps - - - - - - - Async Texture Loading - - - - - - - Precache Textures - - - - - - - Load Textures - - - - - - - Dump FMV Textures - - - - - -