ShuriZma
/
pcsx2
mirror of https://github.com/PCSX2/pcsx2.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

GS:Capture: Prefer h264 as the default codec 

FFmpeg's default is mpeg4 for a number of containers if it was compiled without x264
This commit is contained in:
TellowKrinkle 2023-06-28 00:40:11 -05:00 committed by TellowKrinkle
parent 9f23755a62
commit 1e32fcaebe
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
pcsx2/GS/GSCapture.cpp
View File

@ -409,8 +409,14 @@ bool GSCapture::BeginCapture(float fps, GSVector2i recommendedResolution, float
fmt::format("Video codec {} not found, using default.", GSConfig.VideoCaptureCodec), Host::OSD_ERROR_DURATION); fmt::format("Video codec {} not found, using default.", GSConfig.VideoCaptureCodec), Host::OSD_ERROR_DURATION);
} }
} }
// FFmpeg decides whether mp4, mkv, etc should use h264 or mpeg4 as their default codec by whether x264 was enabled
// But there's a lot of other h264 encoders (e.g. hardware encoders) we may want to use instead
if (!vcodec && wrap_avformat_query_codec(output_format, AV_CODEC_ID_H264, FF_COMPLIANCE_NORMAL))
vcodec = wrap_avcodec_find_encoder(AV_CODEC_ID_H264);
if (!vcodec) if (!vcodec)
vcodec = wrap_avcodec_find_encoder(output_format->video_codec); vcodec = wrap_avcodec_find_encoder(output_format->video_codec);
if (!vcodec) if (!vcodec)
{ {
Host::AddIconOSDMessage("GSCaptureError", ICON_FA_CAMERA, "Failed to find video encoder.", Host::OSD_ERROR_DURATION); Host::AddIconOSDMessage("GSCaptureError", ICON_FA_CAMERA, "Failed to find video encoder.", Host::OSD_ERROR_DURATION);