ShuriZma
/
pcsx2
mirror of https://github.com/PCSX2/pcsx2.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Sif: Renamed a few functions. Added a check on fifo reading/writing. A few other minor changes. 

git-svn-id: http://pcsx2.googlecode.com/svn/trunk@2527 96395faa-99c1-11dd-bbfe-3dabce05a288
This commit is contained in:
arcum42 2010-01-27 13:28:43 +00:00
parent fc5a91096e
commit 18fbbb613b
2 changed files with 106 additions and 63 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

72
pcsx2/Sif.cpp
View File

@ -36,9 +36,11 @@ void sifInit()
// Various read/write functions. Could probably be reduced.
static __forceinline bool SifEERead(int &cycles)
{
const int readSize = min((s32)sif0dma->qwc, sif0.fifo.size >> 2);
//if (readSize <= 0)
//{
tDMA_TAG *ptag;
int readSize = min((s32)sif0dma->qwc, (sif0.fifo.size >> 2));
if (readSize == 0) { /*Console.Warning("SifEERead readSize is 0"); return false;*/}
//SIF_LOG(" EE SIF doing transfer %04Xqw to %08X", readSize, sif0dma->madr);
SIF_LOG("----------- %lX of %lX", readSize << 2, sif0dma->qwc << 2);
@ -57,16 +59,28 @@ static __forceinline bool SifEERead(int &cycles)
sif0dma->madr += readSize << 4;
cycles += readSize; // fixme : BIAS is factored in above
sif0dma->qwc -= readSize;
//}
//else
//{
//DevCon.Warning("SifEERead readSize is 0");
// return false;
//}
return true;
}
static __forceinline bool SifEEWrite(int &cycles)
{
// There's some data ready to transfer into the fifo..
tDMA_TAG *ptag;
const int writeSize = min((s32)sif1dma->qwc, (FIFO_SIF_W - sif1.fifo.size) / 4);
if (writeSize == 0) { /*Console.Warning("SifEEWrite writeSize is 0"); return false;*/ }
const int writeSize = min((s32)sif1dma->qwc, sif1.fifo.free() >> 2);
//if (writeSize <= 0)
//{
//DevCon.Warning("SifEEWrite writeSize is 0");
// return false;
//}
//else
//{
tDMA_TAG *ptag;
ptag = sif1dma->getAddr(sif1dma->madr, DMAC_SIF1);
if (ptag == NULL)
@ -80,37 +94,55 @@ static __forceinline bool SifEEWrite(int &cycles)
sif1dma->madr += writeSize << 4;
cycles += writeSize; // fixme : BIAS is factored in above
sif1dma->qwc -= writeSize;
//}
return true;
}
static __forceinline void SifIOPWrite(int &psxCycles)
static __forceinline bool SifIOPWrite(int &psxCycles)
{
// There's some data ready to transfer into the fifo..
int writeSize = min(sif0.counter, FIFO_SIF_W - sif0.fifo.size);
if (writeSize == 0) { /*Console.Warning("SifIOPWrite writeSize is 0"); return;*/ }
const int writeSize = min(sif0.counter, sif0.fifo.free());
//if (writeSize <= 0)
//{
//DevCon.Warning("SifIOPWrite writeSize is 0");
// return false;
//}
//else
//{
SIF_LOG("+++++++++++ %lX of %lX", writeSize, sif0.counter);
sif0.fifo.write((u32*)iopPhysMem(HW_DMA9_MADR), writeSize);
HW_DMA9_MADR += writeSize << 2;
psxCycles += (writeSize / 4) * BIAS; // fixme : should be / 16
psxCycles += (writeSize >> 2) * BIAS; // fixme : should be >> 4
sif0.counter -= writeSize;
//}
return true;
}
static __forceinline void SifIOPRead(int &psxCycles)
static __forceinline bool SifIOPRead(int &psxCycles)
{
// If we're reading something, continue to do so.
const int readSize = min (sif1.counter, sif1.fifo.size);
if (readSize == 0) { /*Console.Warning("SifIOPRead readSize is 0"); return;*/ }
//if (readSize <= 0)
//{
//DevCon.Warning("SifIOPRead readSize is 0");
// return false;
//}
//else
//{
SIF_LOG(" IOP SIF doing transfer %04X to %08X", readSize, HW_DMA10_MADR);
sif1.fifo.read((u32*)iopPhysMem(HW_DMA10_MADR), readSize);
psxCpu->Clear(HW_DMA10_MADR, readSize);
HW_DMA10_MADR += readSize << 2;
psxCycles += readSize / 4; // fixme: should be / 16
psxCycles += readSize >> 2; // fixme: should be / 16
sif1.counter -= readSize;
//}
return true;
}
static __forceinline bool SIF0EEReadTag()
static __forceinline bool SIFEEReadTag()
{
static __aligned16 u32 tag[4];
@ -150,7 +182,7 @@ static __forceinline bool SIF0EEReadTag()
return true;
}
static __forceinline bool SIF1EEWriteTag()
static __forceinline bool SIFEEWriteTag()
{
// Chain mode
tDMA_TAG *ptag;
@ -216,7 +248,7 @@ static __forceinline bool SIF1EEWriteTag()
return true;
}
static __forceinline bool SIF0IOPWriteTag()
static __forceinline bool SIFIOPWriteTag()
{
// Process DMA tag at HW_DMA9_TADR
sif0.data = *(sifData *)iopPhysMem(HW_DMA9_TADR);
@ -232,7 +264,7 @@ static __forceinline bool SIF0IOPWriteTag()
return true;
}
static __forceinline bool SIF1IOPWriteTag()
static __forceinline bool SIFIOPReadTag()
{
// Read a tag.
sif1.fifo.read((u32*)&sif1.data, 4);
@ -334,7 +366,7 @@ static __forceinline void SIF0EEDma(int &cycles, bool &done)
else if (sif0.fifo.size >= 4) // Read a tag
{
done = false;
SIF0EEReadTag();
SIFEEReadTag();
}
}
@ -365,7 +397,7 @@ static __forceinline void SIF1EEDma(int &cycles, bool &done)
else
{
done = false;
if (!SIF1EEWriteTag()) return;
if (!SIFEEWriteTag()) return;
}
}
else
@ -387,7 +419,7 @@ static __forceinline void SIF0IOPDma(int &psxCycles, bool &done)
else // Chain mode
{
done = false;
SIF0IOPWriteTag();
SIFIOPWriteTag();
}
}
else
@ -414,7 +446,7 @@ static __forceinline void SIF1IOPDma(int &psxCycles, bool &done)
{
done = false;
SIF1IOPWriteTag();
SIFIOPReadTag();
}
}
}

11
pcsx2/Sif.h
View File

@ -33,7 +33,14 @@ struct sifFifo
s32 writePos;
s32 size;
s32 free()
{
return FIFO_SIF_W - size;
}
void write(u32 *from, int words)
{
if (words > 0)
{
const int wP0 = min((FIFO_SIF_W - writePos), words);
const int wP1 = words - wP0;
@ -43,10 +50,13 @@ struct sifFifo
writePos = (writePos + words) & (FIFO_SIF_W - 1);
size += words;
}
SIF_LOG(" SIF + %d = %d (pos=%d)", words, size, writePos);
}
void read(u32 *to, int words)
{
if (words > 0)
{
const int wP0 = min((FIFO_SIF_W - readPos), words);
const int wP1 = words - wP0;
@ -56,6 +66,7 @@ struct sifFifo
readPos = (readPos + words) & (FIFO_SIF_W - 1);
size -= words;
}
SIF_LOG(" SIF - %d = %d (pos=%d)", words, size, readPos);
}
};