Misc: Latest round of warning cleanups

This commit is contained in:
Connor McLaughlin 2023-01-12 19:15:55 +10:00 committed by lightningterror
parent 95fa15f902
commit 0bca1aab74
6 changed files with 5 additions and 12 deletions

View File

@ -170,12 +170,6 @@ void x86capabilities::CountCores()
{
Identify();
s32 regs[4];
u32 cmds;
cpuid(regs, 0x80000000);
cmds = regs[0];
// This will assign values into LogicalCores and PhysicalCores
CountLogicalCores();
}

View File

@ -177,7 +177,7 @@ void BreakpointDialog::accept()
m_bpModel.removeRows(m_rowIndex, 1);
}
m_bpModel.insertRows(0, 1, {m_bp_mc});
m_bpModel.insertBreakpointRows(0, 1, {m_bp_mc});
QDialog::accept();
}

View File

@ -306,9 +306,9 @@ bool BreakpointModel::removeRows(int row, int count, const QModelIndex& index)
return true;
}
bool BreakpointModel::insertRows(int row, int count, std::vector<BreakpointMemcheck> breakpoints, const QModelIndex& index)
bool BreakpointModel::insertBreakpointRows(int row, int count, std::vector<BreakpointMemcheck> breakpoints, const QModelIndex& index)
{
if (breakpoints.size() != count)
if (breakpoints.size() != static_cast<size_t>(count))
return false;
beginInsertRows(index, row, row + count);

View File

@ -47,7 +47,7 @@ public:
Qt::ItemFlags flags(const QModelIndex& index) const override;
bool setData(const QModelIndex& index, const QVariant& value, int role) override;
bool removeRows(int row, int count, const QModelIndex& index = QModelIndex()) override;
bool insertRows(int row, int count, std::vector<BreakpointMemcheck> breakpoints, const QModelIndex& index = QModelIndex());
bool insertBreakpointRows(int row, int count, std::vector<BreakpointMemcheck> breakpoints, const QModelIndex& index = QModelIndex());
BreakpointMemcheck at(int row) const { return m_breakpoints.at(row); };

View File

@ -79,7 +79,7 @@ QVariant ThreadModel::data(const QModelIndex& index, int role) const
}
else if (role == Qt::UserRole)
{
const auto& thread = getEEThreads().at(index.row());
const auto thread = getEEThreads().at(index.row());
switch (index.column())
{

View File

@ -28,7 +28,6 @@
#include "SettingWidgetBinder.h"
#include "SettingsDialog.h"
static constexpr s32 DEFAULT_INTERPOLATION_MODE = 5;
static constexpr s32 DEFAULT_SYNCHRONIZATION_MODE = 0;
static constexpr s32 DEFAULT_EXPANSION_MODE = 0;
static constexpr s32 DEFAULT_DPL_DECODING_LEVEL = 0;