From 0af2e4af03a7c1ca8e24f311b1416a8a18503f8d Mon Sep 17 00:00:00 2001 From: Connor McLaughlin Date: Tue, 4 Oct 2022 00:43:51 +1000 Subject: [PATCH] Achievements: Avoid potential crash when parsing malformed responses --- pcsx2/Frontend/Achievements.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pcsx2/Frontend/Achievements.cpp b/pcsx2/Frontend/Achievements.cpp index ae80fc90fa..dc18e8dbe8 100644 --- a/pcsx2/Frontend/Achievements.cpp +++ b/pcsx2/Frontend/Achievements.cpp @@ -287,7 +287,7 @@ namespace Achievements data.push_back(0); const int error = ParseFunc(this, reinterpret_cast(data.data())); - initialized = true; + initialized = (error == RC_OK); const rc_api_response_t& response = static_cast(this)->response; if (error != RC_OK)