From 0967f9bcfcb15ac35adbaa8a17ca3b235ea07aba Mon Sep 17 00:00:00 2001 From: Jonathan Li Date: Sat, 21 Sep 2019 22:29:23 +0100 Subject: [PATCH] cdvdgigaherz: Prevent potential infinite loop on ini read Fixes a condition where a file read error could cause an infinite loop. --- plugins/cdvdGigaherz/src/Settings.cpp | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/plugins/cdvdGigaherz/src/Settings.cpp b/plugins/cdvdGigaherz/src/Settings.cpp index 4fc95a9f8c..355652b4f0 100644 --- a/plugins/cdvdGigaherz/src/Settings.cpp +++ b/plugins/cdvdGigaherz/src/Settings.cpp @@ -54,10 +54,8 @@ void Settings::Load(const std::string &filename) if (!file.is_open()) return; - while (!file.eof()) { - std::string line; - std::getline(file, line); - + std::string line; + while (std::getline(file, line)) { auto separator = line.find('='); if (separator == std::string::npos) continue;