From 060a8f63451251cd8bf51b04805889f1c211ce04 Mon Sep 17 00:00:00 2001
From: lightningterror <18107717+lightningterror@users.noreply.github.com>
Date: Wed, 24 Aug 2022 03:45:09 +0200
Subject: [PATCH] PAD: Fix variable initializations.

Codacy Warning: Variable 'variable' is assigned in constructor body. Consider performing initialization in initialization list
---
 pcsx2/PAD/Linux/wx_dialog/GamepadConfiguration.cpp |  4 ++--
 pcsx2/PAD/Windows/DirectInput.cpp                  |  2 +-
 pcsx2/PAD/Windows/WndProcEater.cpp                 | 12 +++++-------
 3 files changed, 8 insertions(+), 10 deletions(-)

diff --git a/pcsx2/PAD/Linux/wx_dialog/GamepadConfiguration.cpp b/pcsx2/PAD/Linux/wx_dialog/GamepadConfiguration.cpp
index 0fc99682c6..d32d0a6b1c 100644
--- a/pcsx2/PAD/Linux/wx_dialog/GamepadConfiguration.cpp
+++ b/pcsx2/PAD/Linux/wx_dialog/GamepadConfiguration.cpp
@@ -18,9 +18,9 @@
 GamepadConfiguration::GamepadConfiguration(int pad, wxWindow* parent)
 	: wxDialog(parent, wxID_ANY, _T("Gamepad"), wxDefaultPosition, wxDefaultSize,
 			   wxSYSTEM_MENU | wxCAPTION | wxCLOSE_BOX | wxCLIP_CHILDREN)
-{
-	m_pad_id = pad;
+	, m_pad_id(pad)
 
+{
 	wxBoxSizer* gamepad_box = new wxBoxSizer(wxVERTICAL);
 
 	wxArrayString choices;
diff --git a/pcsx2/PAD/Windows/DirectInput.cpp b/pcsx2/PAD/Windows/DirectInput.cpp
index a41857487e..b42100c956 100644
--- a/pcsx2/PAD/Windows/DirectInput.cpp
+++ b/pcsx2/PAD/Windows/DirectInput.cpp
@@ -137,9 +137,9 @@ public:
 	GUID guidInstance;
 	DirectInputDevice(DeviceType type, IDirectInputDevice8* did, wchar_t* displayName, wchar_t* instanceID, wchar_t* productID, GUID guid)
 		: Device(DI, type, displayName, instanceID, productID)
+		, guidInstance(guid)
 	{
 		diEffects = 0;
-		guidInstance = guid;
 		this->did = 0;
 		did->EnumEffects(EnumEffectsCallback, this, DIEFT_ALL);
 		did->EnumObjects(EnumDeviceObjectsCallback, this, DIDFT_ALL);
diff --git a/pcsx2/PAD/Windows/WndProcEater.cpp b/pcsx2/PAD/Windows/WndProcEater.cpp
index 7185c0b50d..ea4b8ba948 100644
--- a/pcsx2/PAD/Windows/WndProcEater.cpp
+++ b/pcsx2/PAD/Windows/WndProcEater.cpp
@@ -18,14 +18,12 @@
 #include "WndProcEater.h"
 
 WndProcEater::WndProcEater()
+	: hWndEaten(0)
+	, eatenWndProc(0)
+	, extraProcs(0)
+	, numExtraProcs(0)
+	, hMutex(CreateMutex(0, 0, L"PAD"))
 {
-	hWndEaten = 0;
-	eatenWndProc = 0;
-
-	extraProcs = 0;
-	numExtraProcs = 0;
-
-	hMutex = CreateMutex(0, 0, L"PAD");
 }
 
 WndProcEater::~WndProcEater() throw()