From 029c11c8d2be124d84c19f8bf0516d5ecfab6aea Mon Sep 17 00:00:00 2001 From: Ty Lamontagne Date: Thu, 27 Apr 2023 21:07:03 -0400 Subject: [PATCH] Debugger: Fix an oversight on how breakpoints are managed --- pcsx2-qt/Debugger/Models/BreakpointModel.cpp | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/pcsx2-qt/Debugger/Models/BreakpointModel.cpp b/pcsx2-qt/Debugger/Models/BreakpointModel.cpp index 1299d15398..03a5d859c2 100644 --- a/pcsx2-qt/Debugger/Models/BreakpointModel.cpp +++ b/pcsx2-qt/Debugger/Models/BreakpointModel.cpp @@ -319,8 +319,12 @@ bool BreakpointModel::insertBreakpointRows(int row, int count, std::vector(count)) return false; - beginInsertRows(index, row, row + count); + beginInsertRows(index, row, row + (count - 1)); + // After endInsertRows, Qt will try and validate our new rows + // Because we add the breakpoints off of the UI thread, our new rows may not be visible yet + // To prevent the (seemingly harmless?) warning emitted by enderInsertRows, add the breakpoints manually here as well + m_breakpoints.insert(m_breakpoints.begin(), breakpoints.begin(), breakpoints.end()); for (const auto& bp_mc : breakpoints) { if (const auto* bp = std::get_if(&bp_mc))