From bdcd0688563a33dd3725b18f4f962f4034ba0ceb Mon Sep 17 00:00:00 2001 From: profi200 Date: Fri, 1 May 2020 21:30:20 +0200 Subject: [PATCH] Added long overdue credits because without them i would still struggle to understand the GPU. A few small changes. Nothing important. --- README.md | 5 ++--- source/arm11/hardware/lgyfb.c | 6 +++--- source/arm11/hardware/lgyfb.dma330 | 4 ++-- 3 files changed, 7 insertions(+), 8 deletions(-) diff --git a/README.md b/README.md index 16dca85..e5c7dfb 100644 --- a/README.md +++ b/README.md @@ -16,9 +16,7 @@ installed in your system. Additionally you need 7-Zip or on Linux p7z installed ## Known issues This section is reserved for a listing of known issues. At present only this remains: * Drops a single frame roughly every 5 seconds. This is due to different refresh rates of the LCDs and the builtin GBA hardware. -* Leaving GBA sleep mode or pressing HOME can cause persistent glitches (double scanlines/shifted picture). -* No scaling for now. This requires the GPU due to timing constraints. -* Save type hardcoded to 32 KiB (256k) SRAM for now. +* Save type hardcoded to 32 KiB (256k) SRAM. Unknown how save type detection will be done. If you happen to stumble over another bug, please open an issue in the [official open_agb_firm repo on GitHub](https://github.com/profi200/open_agb_firm/issues) or contact me via other platforms. @@ -36,6 +34,7 @@ You may use this under the terms of the GNU General Public License GPL v3 or und * **devkitPro** * **ChaN** * **fastboot3DS project** +* **Wolfvak, Sono and all the other people on GodMode9 IRC/Discord** * ...everyone who contributed to **3dbrew.org** Copyright (C) 2020 derrek, profi200, d0k3 diff --git a/source/arm11/hardware/lgyfb.c b/source/arm11/hardware/lgyfb.c index f83d412..886365e 100644 --- a/source/arm11/hardware/lgyfb.c +++ b/source/arm11/hardware/lgyfb.c @@ -196,12 +196,12 @@ alignas(16) static const u8 secondList[448] = 0x10, 0x00, 0x0F, 0x00 }; - static bool firstRender = false; + static bool normalRender = false; u32 listSize; const u32 *list; - if(firstRender == false) + if(normalRender == false) { - firstRender = true; + normalRender = true; listSize = 1136; list = (u32*)firstList; diff --git a/source/arm11/hardware/lgyfb.dma330 b/source/arm11/hardware/lgyfb.dma330 index f6cbc64..37fb75f 100644 --- a/source/arm11/hardware/lgyfb.dma330 +++ b/source/arm11/hardware/lgyfb.dma330 @@ -1,7 +1,7 @@ # 8 bytes burst with 4 transfers. Total 32 bytes per burst. # Source fixed address and destination incrementing. -# Source and destination privileged data access. -MOV CCR, SB4 SS64 SAF SP3 DB4 DS64 DAI DP3 +# Source and destination unprivileged, non-secure data access. +MOV CCR, SB4 SS64 SAF SP2 DB4 DS64 DAI DP2 MOV SAR, 0x10311000 MOV DAR, 0x18400000