From fe37fa2ab2ddc3ff275d69cf10b5b0a31cd05aaa Mon Sep 17 00:00:00 2001 From: Johan Mattsson <39247600+j-mattsson@users.noreply.github.com> Date: Wed, 1 Jan 2025 15:04:14 +0100 Subject: [PATCH] Fix potential index out of bounds in DisplayQt.cpp --- src/platform/qt/DisplayQt.cpp | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/platform/qt/DisplayQt.cpp b/src/platform/qt/DisplayQt.cpp index b71147c43..3f46872f4 100644 --- a/src/platform/qt/DisplayQt.cpp +++ b/src/platform/qt/DisplayQt.cpp @@ -209,7 +209,7 @@ void DisplayQt::deinit(struct VideoBackend*) { void DisplayQt::setLayerDimensions(struct VideoBackend* v, enum VideoLayer layer, const struct mRectangle* dims) { DisplayQt* self = static_cast(v->user); - if (layer > self->m_layerDims.size()) { + if (layer >= self->m_layerDims.size()) { return; } self->m_layerDims[layer] = QRect(dims->x, dims->y, dims->width, dims->height); @@ -217,7 +217,7 @@ void DisplayQt::setLayerDimensions(struct VideoBackend* v, enum VideoLayer layer void DisplayQt::layerDimensions(const struct VideoBackend* v, enum VideoLayer layer, struct mRectangle* dims) { DisplayQt* self = static_cast(v->user); - if (layer > self->m_layerDims.size()) { + if (layer >= self->m_layerDims.size()) { return; } QRect rect = self->m_layerDims[layer]; @@ -238,7 +238,7 @@ void DisplayQt::contextResized(struct VideoBackend*, unsigned, unsigned, unsigne void DisplayQt::setImageSize(struct VideoBackend* v, enum VideoLayer layer, int w, int h) { DisplayQt* self = static_cast(v->user); - if (layer > self->m_layers.size()) { + if (layer >= self->m_layers.size()) { return; } self->m_layers[layer] = QImage(w, h, QImage::Format_ARGB32); @@ -246,7 +246,7 @@ void DisplayQt::setImageSize(struct VideoBackend* v, enum VideoLayer layer, int void DisplayQt::imageSize(struct VideoBackend* v, enum VideoLayer layer, int* w, int* h) { DisplayQt* self = static_cast(v->user); - if (layer > self->m_layers.size()) { + if (layer >= self->m_layers.size()) { return; } *w = self->m_layers[layer].width(); @@ -255,7 +255,7 @@ void DisplayQt::imageSize(struct VideoBackend* v, enum VideoLayer layer, int* w, void DisplayQt::setImage(struct VideoBackend* v, enum VideoLayer layer, const void* frame) { DisplayQt* self = static_cast(v->user); - if (layer > self->m_layers.size()) { + if (layer >= self->m_layers.size()) { return; } QImage& image = self->m_layers[layer];