ShuriZma
/
mgba
mirror of https://github.com/mgba-emu/mgba.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

GB MBC: Remove erroneous bank 0 wrapping

This commit is contained in:
Vicki Pfau 2017-11-05 21:05:06 -08:00
parent 7fd3eb722b
commit fb939ab042
6 changed files with 1 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
CHANGES
View File

@ -38,6 +38,7 @@ Misc:
- Qt: Prevent window from being created off-screen - Qt: Prevent window from being created off-screen
- Qt: Add option to disable FPS display - Qt: Add option to disable FPS display
- GBA: Improve multiboot image detection - GBA: Improve multiboot image detection
- GB MBC: Remove erroneous bank 0 wrapping
0.6.1: (2017-10-01) 0.6.1: (2017-10-01)
Bugfixes: Bugfixes:

1
cinema/gb/mooneye-gb/emulator-only/mbc1/rom_1Mb/manifest.yml
View File

@ -1 +0,0 @@
fail: true

1
cinema/gb/mooneye-gb/emulator-only/mbc1/rom_2Mb/manifest.yml
View File

@ -1 +0,0 @@
fail: true

BIN
cinema/gb/mooneye-gb/emulator-only/mbc1/rom_512Kb/baseline_0000.png
View File

Binary file not shown.
Side by Side Swipe Overlay

Before

Width:  |  Height:  |  Size: 1.2 KiB

After

Width:  |  Height:  |  Size: 518 B

1
cinema/gb/mooneye-gb/emulator-only/mbc1_rom_4banks/manifest.yml
View File

@ -1 +0,0 @@
fail: true

3
src/gb/mbc.c
View File

@ -45,9 +45,6 @@ void GBMBCSwitchBank(struct GB* gb, int bank) {
mLOG(GB_MBC, GAME_ERROR, "Attempting to switch to an invalid ROM bank: %0X", bank); mLOG(GB_MBC, GAME_ERROR, "Attempting to switch to an invalid ROM bank: %0X", bank);
bankStart &= (gb->memory.romSize - 1); bankStart &= (gb->memory.romSize - 1);
bank = bankStart / GB_SIZE_CART_BANK0; bank = bankStart / GB_SIZE_CART_BANK0;
if (!bank) {
++bank;
}
} }
gb->memory.romBank = &gb->memory.rom[bankStart]; gb->memory.romBank = &gb->memory.rom[bankStart];
gb->memory.currentBank = bank; gb->memory.currentBank = bank;