diff --git a/CHANGES b/CHANGES index b79c97ed4..af727a99d 100644 --- a/CHANGES +++ b/CHANGES @@ -54,6 +54,7 @@ Misc: - Qt: Disable Replace ROM option when no game loaded - Qt: Defer texture updates until frame is drawn (fixes mgba.io/i/1590) - Qt: Set icon for Discord Rich Presence + - Qt: Show a warning when save file can't be opened 0.8.1: (2020-02-16) Emulation fixes: diff --git a/src/gba/gba.c b/src/gba/gba.c index d306005a7..b195ea611 100644 --- a/src/gba/gba.c +++ b/src/gba/gba.c @@ -432,7 +432,7 @@ bool GBALoadROM(struct GBA* gba, struct VFile* vf) { bool GBALoadSave(struct GBA* gba, struct VFile* sav) { GBASavedataInit(&gba->memory.savedata, sav); - return true; + return sav; } void GBAYankROM(struct GBA* gba) { diff --git a/src/platform/qt/CoreManager.cpp b/src/platform/qt/CoreManager.cpp index 6b2a64f09..cdf38f1c9 100644 --- a/src/platform/qt/CoreManager.cpp +++ b/src/platform/qt/CoreManager.cpp @@ -109,7 +109,9 @@ CoreController* CoreManager::loadGame(VFile* vf, const QString& path, const QStr } bytes = info.dir().canonicalPath().toUtf8(); mDirectorySetAttachBase(&core->dirs, VDirOpen(bytes.constData())); - mCoreAutoloadSave(core); + if (!mCoreAutoloadSave(core)) { + LOG(QT, ERROR) << tr("Failed to open save file. Is the save directory writable?"); + } mCoreAutoloadCheats(core); CoreController* cc = new CoreController(core);