ShuriZma
/
mgba
mirror of https://github.com/mgba-emu/mgba.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

GBA BIOS: Division by zero sometimes doesn't crash

This commit is contained in:
Vicki Pfau 2020-09-19 00:27:30 -07:00
parent ca67e63abb
commit e83a371e50
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/gba/bios.c
View File

@ -277,7 +277,11 @@ static void _MidiKey2Freq(struct GBA* gba) {
static void _Div(struct GBA* gba, int32_t num, int32_t denom) {
struct ARMCore* cpu = gba->cpu;
if (denom == 0) {
mLOG(GBA_BIOS, FATAL, "Attempting to divide %i by zero!", num);
if (num == 0 || num == -1 || num == 1) {
mLOG(GBA_BIOS, GAME_ERROR, "Attempting to divide %i by zero!", num);
} else {
mLOG(GBA_BIOS, FATAL, "Attempting to divide %i by zero!", num);
}
// If abs(num) > 1, this should hang, but that would be painful to
// emulate in HLE, and no game will get into a state under normal
// operation where it hangs...