ShuriZma
/
mgba
mirror of https://github.com/mgba-emu/mgba.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Script: Fix table string key UAF

This commit is contained in:
Vicki Pfau 2023-01-31 17:19:01 -08:00
parent 5a5adc1b15
commit e445baaf14
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/script/engines/lua.c
View File

@ -584,7 +584,11 @@ struct mScriptValue* _luaCoerceTable(struct mScriptEngineContextLua* luaContext)
return false; return false;
} }
mScriptTableInsert(table, key, value); mScriptTableInsert(table, key, value);
mScriptValueDeref(key); if (key->type != mSCRIPT_TYPE_MS_STR) {
// Strings are added to the ref pool, so we need to keep it
// ref'd to prevent it from being collected prematurely
mScriptValueDeref(key);
}
mScriptValueDeref(value); mScriptValueDeref(value);
} }
lua_pop(luaContext->lua, 1); lua_pop(luaContext->lua, 1);