ShuriZma
/
mgba
mirror of https://github.com/mgba-emu/mgba.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix buffer underrun in mode 0 rendering

This commit is contained in:
Jeffrey Pfau 2013-09-22 03:59:33 -07:00
parent 2ce017b555
commit ddf078383a
1 changed files with 12 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/gba/renderers/video-software.c
View File

@ -896,23 +896,31 @@ static void _drawBackgroundMode0(struct GBAVideoSoftwareRenderer* renderer, stru
tileData = ((uint32_t*)renderer->d.vram)[charBase]; tileData = ((uint32_t*)renderer->d.vram)[charBase];
paletteData = mapData.palette << 4; paletteData = mapData.palette << 4;
if (!mapData.hflip) { if (!mapData.hflip) {
outX = renderer->end - mod8;
if (outX < 0) {
outX = 0;
}
if (!variant) { if (!variant) {
for (outX = renderer->end - mod8; outX < renderer->end; ++outX) { for (; outX < renderer->end; ++outX) {
BACKGROUND_DRAW_PIXEL_16_NORMAL; BACKGROUND_DRAW_PIXEL_16_NORMAL;
} }
} else { } else {
for (outX = renderer->end - mod8; outX < renderer->end; ++outX) { for (; outX < renderer->end; ++outX) {
BACKGROUND_DRAW_PIXEL_16_VARIANT; BACKGROUND_DRAW_PIXEL_16_VARIANT;
} }
} }
} else { } else {
tileData >>= 4 * (0x8 - mod8); tileData >>= 4 * (0x8 - mod8);
int end2 = renderer->end - 8;
if (end2 < -1) {
end2 = -1;
}
if (!variant) { if (!variant) {
for (outX = renderer->end - 1; outX > renderer->end - 8; --outX) { for (outX = renderer->end - 1; outX > end2; --outX) {
BACKGROUND_DRAW_PIXEL_16_NORMAL; BACKGROUND_DRAW_PIXEL_16_NORMAL;
} }
} else { } else {
for (outX = renderer->end - 1; outX > renderer->end - 8; --outX) { for (outX = renderer->end - 1; outX > end2; --outX) {
BACKGROUND_DRAW_PIXEL_16_VARIANT; BACKGROUND_DRAW_PIXEL_16_VARIANT;
} }
} }